From: Patrick McHardy <kaber@trash.net>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: Phil Oester <kernel@linuxace.com>,
cedric@schieli.dyndns.org, coreteam@netfilter.org,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org
Subject: Re: [netfilter-core] Re: [PATCH] Avoid unncessary checksum validation in TCP/UDP netfilter
Date: Sun, 12 Jun 2005 17:06:03 +0200 [thread overview]
Message-ID: <42AC4F5B.1040907@trash.net> (raw)
In-Reply-To: <875052371a3a7c5217e413d7250320f9@cl.cam.ac.uk>
Keir Fraser wrote:
> On 27 May 2005, at 12:20, Phil Oester wrote:
>> On Fri, May 27, 2005 at 12:03:08PM +0100, Keir Fraser wrote:
>>
>>> The TCP/UDP connection-tracking code in netfilter validates the
>>> checksum of incoming packets, to prevent nastier errors further down
>>> the road. This check is unnecessary if the skb is marked as
>>> CHECKSUM_UNNECESSARY.
>>
>> It seems at least part of this has already been merged in 2.6.12-rc
>
> It would be great if the UDP code also would observe
> CHECKSUM_UNNECESSARY. I'll wait for 2.6.12 to appear and then submit a
> new patch if UDP has been missed.
TCP was changed to fix a regression with loopback packets. I've added
the UDP part of your patch to my 2.6.13 tree.
Regards
Patrick
prev parent reply other threads:[~2005-06-12 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-27 11:03 [PATCH] Avoid unncessary checksum validation in TCP/UDP netfilter Keir Fraser
2005-05-27 11:20 ` Phil Oester
2005-05-28 8:48 ` Keir Fraser
2005-06-12 15:06 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42AC4F5B.1040907@trash.net \
--to=kaber@trash.net \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=cedric@schieli.dyndns.org \
--cc=coreteam@netfilter.org \
--cc=kernel@linuxace.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox