From: Rommer <rommer@active.by>
To: Bernd Petrovitsch <bernd@firmix.at>
Cc: "Måns Rullgård" <mru@inprovide.com>, linux-kernel@vger.kernel.org
Subject: Re: udp.c
Date: Mon, 13 Jun 2005 15:54:20 +0300 [thread overview]
Message-ID: <42AD81FC.9020404@active.by> (raw)
In-Reply-To: <1118666058.898.23.camel@tara.firmix.at>
Hello,
So, why BUG(), not just void function?
Bernd Petrovitsch wrote:
> On Mon, 2005-06-13 at 14:24 +0200, Måns Rullgård wrote:
>
>>Bernd Petrovitsch <bernd@firmix.at> writes:
>>
>>
>>>On Mon, 2005-06-13 at 14:57 +0300, Rommer wrote:
>>>
>>>>Where used strange function udp_v4_hash?
>>>>linux-2.6.11.11, net/ipv4/udp.c:204
>>>>
>>>>static void udp_v4_hash(struct sock *sk)
>>>
>>>Since it is "static" the user must be in the same source file (or -
>>>theoretically - any included header).
>>
>>It's not that simple. It is assigned to the 'hash' field of a struct
>
>
> If you interpret "called" word-by-word yes. I assumed "used".
>
>
>>proto, which is exported. It could be used from anywhere, but
>
>
> The the OP has to grep for dereferences for this hash variable and check
> if it is (or may be) from the given struct.
> Well, that's the virtue of object-orientation: Follow the objects, not
> the functions/methods.
>
>
>>hopefully isn't. Something else is supposed to ensure that it is
>>never called when using the UDP protocol.
>
>
> Apparently.
>
> Bernd
--
Best regards, Roman
next prev parent reply other threads:[~2005-06-13 12:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-13 11:57 udp.c Rommer
2005-06-13 12:03 ` udp.c Bernd Petrovitsch
2005-06-13 12:24 ` udp.c Måns Rullgård
2005-06-13 12:34 ` udp.c Bernd Petrovitsch
2005-06-13 12:54 ` Rommer [this message]
2005-06-13 12:57 ` udp.c Bernd Petrovitsch
2005-06-13 13:00 ` udp.c Måns Rullgård
2005-06-13 17:23 ` udp.c Jesper Juhl
2005-06-13 19:45 ` udp.c David S. Miller
2005-06-13 21:42 ` udp.c Herbert Xu
2005-06-13 21:57 ` udp.c David S. Miller
2005-06-13 23:04 ` udp.c Herbert Xu
2005-06-13 23:20 ` udp.c David S. Miller
2005-06-13 23:53 ` udp.c Andi Kleen
2005-06-14 0:00 ` udp.c David S. Miller
2005-06-14 0:12 ` udp.c Andi Kleen
2005-06-14 1:11 ` udp.c David S. Miller
2005-06-13 12:08 ` udp.c Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42AD81FC.9020404@active.by \
--to=rommer@active.by \
--cc=bernd@firmix.at \
--cc=linux-kernel@vger.kernel.org \
--cc=mru@inprovide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox