Re: [RFD] FS behavior (I/O failure) in kernel summit

Jeff Mahoney
2005-06-15T17:39:38Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hans Reiser wrote:
> Jeff, would you be willing to make a proposal for what should be done?
> I would be interested in your suggestions.
>
> Jeff Mahoney wrote:
>
>>Hans -
>>
>>These tests must have been run on a kernel prior to 2.6.10-rc1. The I/O
>>error code exhibits behavior similar to ext3, so (1b). There are still
>>kinks to be worked out, but it's definitely not the "throw up our arms
>>and give up" that it used to be.
>>
>>Implementing behavior 1a for ext3 and reiserfs should be fairly trivial
>>- it just means that tests to check if the filesystem is in an aborted
>>state ("shutdown" in xfs terms) need to added to the call path in some
>>places, and be moved earlier in others.

Well it seems to me that all the XFS code does is check to see if the FS
is in a shutdown state really early in the call path. Adding a
super->s_errno or MS_ABORTED flag (i prefer the former, for flexibility)
to the VFS level to be checked before calling into the filesystem would
add the consistent behavior to all filesystems.

As far as the ReiserFS support goes, I was premature in stating that
ReiserFS supports behavior 1b. It does so in terms of journal errors,
but it does just warn and continue on other errors. I'm working on a
patch that introduces reiserfs_error() similar to ext3_error() that
replaces the warnings in many places. The behavior is configurable using
the mount options introduced with the i/o error patches.

- -Jeff

- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCsGe2LPWxlyuTD7IRAhDjAJ0dSbQlWTrK4q91CDToT8TQjnyHggCfS+cm
WWwx8wdwGPvDdB54VE/9rgU=
=c2s6
-----END PGP SIGNATURE-----