public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Liontooth <liontooth@cogweb.net>
To: linux-kernel@vger.kernel.org
Cc: Linux and Kernel Video <video4linux-list@redhat.com>,
	Mauro Carvalho Chehab <mchehab@brturbo.com.br>,
	Michael Schimek <mschimek@gmx.at>
Subject: Re: [PATCH3/5] Synchronize patch for SAA7134 cards
Date: Wed, 15 Jun 2005 02:30:34 -0700	[thread overview]
Message-ID: <42AFF53A.5060107@cogweb.net> (raw)
In-Reply-To: <20050614170137.690e0328.akpm@osdl.org>

Andrew Morton wrote:

>Mauro Carvalho Chehab <mchehab@brturbo.com.br> wrote:
>  
>
>>--- linux-2.6.12/drivers/media/video/saa7134/saa7134-video.c	2005-06-07 15:39:55.000000000 -0300
>>+++ linux/drivers/media/video/saa7134/saa7134-video.c	2005-06-12 01:22:34.000000000 -0300
>>@@ -1,5 +1,5 @@
>> /*
>>...
>> 		.h_start       = 0,
>> 		.h_stop        = 719,
>>- 		.video_v_start = 23,
>>- 		.video_v_stop  = 262,
>>- 		.vbi_v_start_0 = 10,
>>- 		.vbi_v_stop_0  = 21,
>>- 		.vbi_v_start_1 = 273,
>>- 		.src_timing    = 7,
>>-
>>+		.video_v_start = 22,
>>+  		.video_v_start = 23,
>>    
>>
>
>That doesn't compile.  I'll assume it's supposed to be 22.
>  
>
Wrong, use 23. In fact don't apply this patch; it's a dud.

Michael Schimek's vbi changes got messed up somewhere along the line.
It should be 23, not 22 as you understandably assume -- Michael included this note in his patch:

+/* mhs 2005-05-14: Properly video capturing should start in line 22,
+   but for some reason video task A will not execute without a one
+   line gap after vbi task A/B ends, if that is enabled. */

With 22, turning on ntsc closed captioning on saa7134 cards will block the video.

Dave

>--
>video4linux-list mailing list
>Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
>https://www.redhat.com/mailman/listinfo/video4linux-list
>  
>

  reply	other threads:[~2005-06-15  9:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-12  4:47 [PATCH3/4] Synchronize patch for SAA7134 cards Mauro Carvalho Chehab
2005-06-12  5:10 ` [PATCH3/5] " Mauro Carvalho Chehab
2005-06-15  0:01   ` Andrew Morton
2005-06-15  9:30     ` David Liontooth [this message]
2005-11-03 18:45       ` 2.6.14 qc-usb oops on amd64 smp David Liontooth
2005-11-04  2:57         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42AFF53A.5060107@cogweb.net \
    --to=liontooth@cogweb.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@brturbo.com.br \
    --cc=mschimek@gmx.at \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox