From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261161AbVFOQ1p (ORCPT ); Wed, 15 Jun 2005 12:27:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261210AbVFOQ1p (ORCPT ); Wed, 15 Jun 2005 12:27:45 -0400 Received: from mail.aknet.ru ([82.179.72.26]:25614 "EHLO mail.aknet.ru") by vger.kernel.org with ESMTP id S261161AbVFOQ0R (ORCPT ); Wed, 15 Jun 2005 12:26:17 -0400 Message-ID: <42B056A3.4040202@aknet.ru> Date: Wed, 15 Jun 2005 20:26:11 +0400 From: Stas Sergeev User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020 X-Accept-Language: ru, en-us, en MIME-Version: 1.0 To: Andrew Morton Cc: linux-kernel@vger.kernel.org, vojtech@ucw.cz Subject: Re: [patch 1/2] pcspeaker driver update References: <42AF2454.8090806@aknet.ru> <20050614134518.68df565d.akpm@osdl.org> In-Reply-To: <20050614134518.68df565d.akpm@osdl.org> Content-Type: multipart/mixed; boundary="------------040701090507070804040806" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org This is a multi-part message in MIME format. --------------040701090507070804040806 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Hello. Andrew Morton wrote: >> Attached one is just a clean-up: >> it removes the extern definitions >> for the i8253_lock and i8259A_lock, >> making the use of the appropriate >> headers instead. > A nice cleanup to make, however we cannot include asm/timer.h from generic > code, because only a few architectures have such a file. OK, what a bugger... Does the attached one look any better? Signed-off-by: stsp@aknet.ru --------------040701090507070804040806 Content-Type: text/x-patch; name="linux-2.6.12-rc6-spinlk1.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="linux-2.6.12-rc6-spinlk1.diff" diff -urN linux-2.6.12-rc6/arch/i386/kernel/apic.c linux-2.6.12-rc6-spinlk/arch/i386/kernel/apic.c --- linux-2.6.12-rc6/arch/i386/kernel/apic.c 2005-06-07 11:11:34.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/arch/i386/kernel/apic.c 2005-06-14 12:57:50.000000000 +0400 @@ -34,6 +34,7 @@ #include #include #include +#include #include @@ -857,7 +858,6 @@ */ static unsigned int __init get_8254_timer_count(void) { - extern spinlock_t i8253_lock; unsigned long flags; unsigned int count; diff -urN linux-2.6.12-rc6/arch/i386/kernel/apm.c linux-2.6.12-rc6-spinlk/arch/i386/kernel/apm.c --- linux-2.6.12-rc6/arch/i386/kernel/apm.c 2005-06-07 11:11:34.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/arch/i386/kernel/apm.c 2005-06-14 12:57:50.000000000 +0400 @@ -228,10 +228,10 @@ #include #include #include +#include #include "io_ports.h" -extern spinlock_t i8253_lock; extern unsigned long get_cmos_time(void); extern void machine_real_restart(unsigned char *, int); @@ -1169,7 +1169,6 @@ { #ifdef INIT_TIMER_AFTER_SUSPEND unsigned long flags; - extern spinlock_t i8253_lock; spin_lock_irqsave(&i8253_lock, flags); /* set the clock to 100 Hz */ diff -urN linux-2.6.12-rc6/arch/i386/kernel/io_apic.c linux-2.6.12-rc6-spinlk/arch/i386/kernel/io_apic.c --- linux-2.6.12-rc6/arch/i386/kernel/io_apic.c 2005-06-07 11:11:34.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/arch/i386/kernel/io_apic.c 2005-06-14 12:57:50.000000000 +0400 @@ -37,6 +37,7 @@ #include #include #include +#include #include @@ -1565,7 +1566,6 @@ void /*__init*/ print_PIC(void) { - extern spinlock_t i8259A_lock; unsigned int v; unsigned long flags; diff -urN linux-2.6.12-rc6/arch/i386/kernel/time.c linux-2.6.12-rc6-spinlk/arch/i386/kernel/time.c --- linux-2.6.12-rc6/arch/i386/kernel/time.c 2005-06-07 11:11:34.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/arch/i386/kernel/time.c 2005-06-14 12:57:50.000000000 +0400 @@ -63,12 +63,12 @@ #include #include +#include #include #include "io_ports.h" -extern spinlock_t i8259A_lock; int pit_latch_buggy; /* extern */ #include "do_timer.h" diff -urN linux-2.6.12-rc6/arch/i386/kernel/timers/timer_cyclone.c linux-2.6.12-rc6-spinlk/arch/i386/kernel/timers/timer_cyclone.c --- linux-2.6.12-rc6/arch/i386/kernel/timers/timer_cyclone.c 2005-06-07 11:11:34.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/arch/i386/kernel/timers/timer_cyclone.c 2005-06-14 12:57:50.000000000 +0400 @@ -17,10 +17,9 @@ #include #include #include +#include #include "io_ports.h" -extern spinlock_t i8253_lock; - /* Number of usecs that the last interrupt was delayed */ static int delay_at_last_interrupt; diff -urN linux-2.6.12-rc6/arch/i386/kernel/timers/timer_pit.c linux-2.6.12-rc6-spinlk/arch/i386/kernel/timers/timer_pit.c --- linux-2.6.12-rc6/arch/i386/kernel/timers/timer_pit.c 2005-06-07 11:11:34.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/arch/i386/kernel/timers/timer_pit.c 2005-06-14 12:57:50.000000000 +0400 @@ -15,9 +15,9 @@ #include #include #include +#include +#include -extern spinlock_t i8259A_lock; -extern spinlock_t i8253_lock; #include "do_timer.h" #include "io_ports.h" @@ -172,7 +172,6 @@ void setup_pit_timer(void) { - extern spinlock_t i8253_lock; unsigned long flags; spin_lock_irqsave(&i8253_lock, flags); diff -urN linux-2.6.12-rc6/arch/i386/kernel/timers/timer_tsc.c linux-2.6.12-rc6-spinlk/arch/i386/kernel/timers/timer_tsc.c --- linux-2.6.12-rc6/arch/i386/kernel/timers/timer_tsc.c 2005-06-07 11:11:34.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/arch/i386/kernel/timers/timer_tsc.c 2005-06-14 12:57:50.000000000 +0400 @@ -17,6 +17,7 @@ #include #include +#include /* processor.h for distable_tsc flag */ #include @@ -35,8 +36,6 @@ int tsc_disable __initdata = 0; -extern spinlock_t i8253_lock; - static int use_tsc; /* Number of usecs that the last interrupt was delayed */ static int delay_at_last_interrupt; diff -urN linux-2.6.12-rc6/arch/i386/mach-voyager/voyager_basic.c linux-2.6.12-rc6-spinlk/arch/i386/mach-voyager/voyager_basic.c --- linux-2.6.12-rc6/arch/i386/mach-voyager/voyager_basic.c 2005-06-07 11:11:31.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/arch/i386/mach-voyager/voyager_basic.c 2005-06-14 12:57:49.000000000 +0400 @@ -30,6 +30,7 @@ #include #include #include +#include /* * Power off function, if any @@ -182,7 +183,6 @@ * and swiftly introduce it to something sharp and * pointy. */ __u16 val; - extern spinlock_t i8253_lock; spin_lock(&i8253_lock); diff -urN linux-2.6.12-rc6/drivers/ide/legacy/hd.c linux-2.6.12-rc6-spinlk/drivers/ide/legacy/hd.c --- linux-2.6.12-rc6/drivers/ide/legacy/hd.c 2005-06-07 11:11:51.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/drivers/ide/legacy/hd.c 2005-06-14 12:58:00.000000000 +0400 @@ -41,6 +41,7 @@ #include #include #include +#include #define REALLY_SLOW_IO #include @@ -160,7 +161,6 @@ unsigned long read_timer(void) { - extern spinlock_t i8253_lock; unsigned long t, flags; int i; diff -urN linux-2.6.12-rc6/drivers/input/gameport/gameport.c linux-2.6.12-rc6-spinlk/drivers/input/gameport/gameport.c --- linux-2.6.12-rc6/drivers/input/gameport/gameport.c 2005-06-07 11:11:49.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/drivers/input/gameport/gameport.c 2005-06-14 12:57:59.000000000 +0400 @@ -22,6 +22,7 @@ #include #include #include +#include /*#include */ @@ -66,7 +67,6 @@ static unsigned int get_time_pit(void) { - extern spinlock_t i8253_lock; unsigned long flags; unsigned int count; diff -urN linux-2.6.12-rc6/drivers/input/joystick/analog.c linux-2.6.12-rc6-spinlk/drivers/input/joystick/analog.c --- linux-2.6.12-rc6/drivers/input/joystick/analog.c 2005-06-07 11:11:49.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/drivers/input/joystick/analog.c 2005-06-14 12:57:59.000000000 +0400 @@ -39,6 +39,7 @@ #include #include #include +#include #define DRIVER_DESC "Analog joystick and gamepad driver" @@ -145,7 +146,6 @@ #define TIME_NAME (cpu_has_tsc?"TSC":"PIT") static unsigned int get_time_pit(void) { - extern spinlock_t i8253_lock; unsigned long flags; unsigned int count; diff -urN linux-2.6.12-rc6/include/asm-i386/8253pit.h linux-2.6.12-rc6-spinlk/include/asm-i386/8253pit.h --- linux-2.6.12-rc6/include/asm-i386/8253pit.h 2005-06-07 11:12:31.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/include/asm-i386/8253pit.h 2005-06-14 12:58:44.000000000 +0400 @@ -5,8 +5,10 @@ #ifndef _8253PIT_H #define _8253PIT_H +#include #include #define PIT_TICK_RATE CLOCK_TICK_RATE +extern spinlock_t i8253_lock; #endif diff -urN linux-2.6.12-rc6/include/asm-alpha/8253pit.h linux-2.6.12-rc6-spinlk/include/asm-alpha/8253pit.h --- linux-2.6.12-rc6/include/asm-alpha/8253pit.h 2005-06-07 11:12:31.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/include/asm-alpha/8253pit.h 2005-06-14 12:58:44.000000000 +0400 @@ -5,6 +5,9 @@ #ifndef _8253PIT_H #define _8253PIT_H +#include + #define PIT_TICK_RATE 1193180UL +extern spinlock_t i8253_lock; #endif diff -urN linux-2.6.12-rc6/include/asm-ppc64/8253pit.h linux-2.6.12-rc6-spinlk/include/asm-ppc64/8253pit.h --- linux-2.6.12-rc6/include/asm-ppc64/8253pit.h 2005-06-07 11:12:31.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/include/asm-ppc64/8253pit.h 2005-06-14 12:58:44.000000000 +0400 @@ -5,6 +5,9 @@ #ifndef _8253PIT_H #define _8253PIT_H +#include + #define PIT_TICK_RATE 1193182UL +extern spinlock_t i8253_lock; #endif diff -urN linux-2.6.12-rc6/include/asm-x86_64/8253pit.h linux-2.6.12-rc6-spinlk/include/asm-x86_64/8253pit.h --- linux-2.6.12-rc6/include/asm-x86_64/8253pit.h 2005-06-07 11:12:31.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/include/asm-x86_64/8253pit.h 2005-06-14 12:58:44.000000000 +0400 @@ -5,6 +5,9 @@ #ifndef _8253PIT_H #define _8253PIT_H +#include + #define PIT_TICK_RATE 1193182UL +extern spinlock_t i8253_lock; #endif diff -urN linux-2.6.12-rc6/include/asm-ppc/8253pit.h linux-2.6.12-rc6-spinlk/include/asm-ppc/8253pit.h --- linux-2.6.12-rc6/include/asm-ppc/8253pit.h 2005-06-07 11:12:31.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/include/asm-ppc/8253pit.h 2005-06-14 12:58:44.000000000 +0400 @@ -5,6 +5,9 @@ #ifndef _8253PIT_H #define _8253PIT_H +#include + #define PIT_TICK_RATE 1193182UL +extern spinlock_t i8253_lock; #endif diff -urN linux-2.6.12-rc6/include/asm-mips/8253pit.h linux-2.6.12-rc6-spinlk/include/asm-mips/8253pit.h --- linux-2.6.12-rc6/include/asm-mips/8253pit.h 2005-06-07 11:12:31.000000000 +0400 +++ linux-2.6.12-rc6-spinlk/include/asm-mips/8253pit.h 2005-06-14 12:58:44.000000000 +0400 @@ -5,6 +5,9 @@ #ifndef _8253PIT_H #define _8253PIT_H +#include + #define PIT_TICK_RATE 1193182UL +extern spinlock_t i8253_lock; #endif --------------040701090507070804040806--