Re: [patch 1/2] pcspeaker driver update

Stas Sergeev
2005-06-16T03:53:12Z

Hello.

Andrew Morton wrote:
> Well not really - for example you now have drivers/input/joystick/analog.c
> including asm/8253pit.h, which not all architectures implement.
> The basic problem is that we have generic code referring to an x86-specific
> lock inside `#ifdef __i386__'.
In this case - what if I simply include
that <asm/8253pit.h> under the same
#ifdefs that are used for the spin-locks?
Or is it not recommended to #ifdef the
includes?