From: Stas Sergeev <stsp@aknet.ru>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, vojtech@ucw.cz
Subject: Re: [patch 1/2] pcspeaker driver update
Date: Thu, 16 Jun 2005 07:53:08 +0400 [thread overview]
Message-ID: <42B0F7A4.50802@aknet.ru> (raw)
In-Reply-To: <20050615133338.398febbc.akpm@osdl.org>
Hello.
Andrew Morton wrote:
> Well not really - for example you now have drivers/input/joystick/analog.c
> including asm/8253pit.h, which not all architectures implement.
> The basic problem is that we have generic code referring to an x86-specific
> lock inside `#ifdef __i386__'.
In this case - what if I simply include
that <asm/8253pit.h> under the same
#ifdefs that are used for the spin-locks?
Or is it not recommended to #ifdef the
includes?
prev parent reply other threads:[~2005-06-16 3:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-14 18:39 [patch 1/2] pcspeaker driver update Stas Sergeev
2005-06-14 20:45 ` Andrew Morton
2005-06-15 16:26 ` Stas Sergeev
2005-06-15 20:33 ` Andrew Morton
2005-06-16 3:53 ` Stas Sergeev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42B0F7A4.50802@aknet.ru \
--to=stsp@aknet.ru \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox