public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <lkml@looxix.net>
To: linux-kernel@vger.kernel.org, roms@lpg.ticalc.org
Subject: [PATCH] drivers/char/tipar.c: off by one array access
Date: Sun, 19 Jun 2005 17:15:30 +0200	[thread overview]
Message-ID: <42B58C12.6020503@looxix.net> (raw)

In the setupt function, the delay variable is initialized with ints[2],
but ints is declared as:
	int ints[2];

Since the module parameter should correspond to:
	tipar=timeout,delay

I suppose that the following patch fix the problem.


Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@looxix.net>

diff --git a/drivers/char/tipar.c b/drivers/char/tipar.c
--- a/drivers/char/tipar.c
+++ b/drivers/char/tipar.c
@@ -407,7 +407,7 @@ tipar_setup(char *str)
                          printk(KERN_WARNING "tipar: bad timeout value (0), "
  				"using default value instead");
  		if (ints[0] > 1) {
-			delay = ints[2];
+			delay = ints[1];
  		}
  	}




             reply	other threads:[~2005-06-19 15:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-19 15:15 Luc Van Oostenryck [this message]
2005-06-20  3:03 ` [PATCH] drivers/char/tipar.c: off by one array access randy_dunlap
2005-06-20 22:35   ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42B58C12.6020503@looxix.net \
    --to=lkml@looxix.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roms@lpg.ticalc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox