Re: [patch] 2.6.12-mm1: saa7134-core.c compile error

From: Michael Krufky <mkrufky@m1k.net>
To: Linux and Kernel Video <video4linux-list@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Mauro Carvalho Chehab <mchehab@brturbo.com.br>,
	kraxel@bytesex.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.6.12-mm1: saa7134-core.c compile error
Date: Mon, 20 Jun 2005 18:19:21 -0400	[thread overview]
Message-ID: <42B740E9.40708@m1k.net> (raw)
In-Reply-To: <20050620094855.GA3666@stusta.de>

Adrian Bunk wrote:

>On Sun, Jun 19, 2005 at 11:30:29PM -0700, Andrew Morton wrote:
>  
>
>>...
>>Changes since 2.6.12-rc6-mm1:
>>...
>>+v4l-update-for-saa7134-cards.patch
>>...
>> v4l updates
>>...
>>    
>>
>
>The bogus saa7134-core.c part of this patch has to be dropped since it 
>causes the following compile error with CONFIG_MODULES=n:
>
><--  snip  -->
>
>...
>  CC      drivers/media/video/saa7134/saa7134-core.o
>drivers/media/video/saa7134/saa7134-core.c: In function `saa7134_fini':
>drivers/media/video/saa7134/saa7134-core.c:1215: error: `pending_registered' undeclared (first use in this function)
>drivers/media/video/saa7134/saa7134-core.c:1215: error: (Each undeclared identifier is reported only once
>drivers/media/video/saa7134/saa7134-core.c:1215: error: for each function it appears in.)
>drivers/media/video/saa7134/saa7134-core.c:1216: error: `pending_notifier' undeclared (first use in this function)
>make[4]: *** [drivers/media/video/saa7134/saa7134-core.o] Error 1
>
><--  snip  -->
>
>
>This patch reverts this bogus patch.
>
>
>Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
>--- linux-2.6.12-mm1-modular/drivers/media/video/saa7134/saa7134-core.c	2005-06-20 10:59:33.000000000 +0200
>+++ linux-2.6.12-mm1-full/drivers/media/video/saa7134/saa7134-core.c	2005-06-20 11:46:20.000000000 +0200
>@@ -1212,8 +1212,10 @@
> 
> static void saa7134_fini(void)
> {
>+#ifdef CONFIG_MODULES
> 	if (pending_registered)
> 		unregister_module_notifier(&pending_notifier);
>+#endif
> 	pci_unregister_driver(&saa7134_pci_driver);
> }
> 
>
>--
>video4linux-list mailing list
>Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
>https://www.redhat.com/mailman/listinfo/video4linux-list
>  
>
committed to video4linux CVS:

/Mon Jun 20 22:06:52 2005 UTC/ (6 minutes, 55 seconds ago) by /mkrufky/

        * saa7134-core.c:
        - Fix kernel compile error with CONFIG_MODULES=n

Signed-off-by: Adrian Bunk <bunk@stusta.de <mailto:bunk@stusta.de>>

Thank you!

-- 
Michael Krufky