Re: [PATCH] Pointer cast warnings in scripts/

Pierre Ossman
2005-06-21T12:49:45Z

Roman Zippel wrote:

>Just adding explicit all over the place is really the worst solution.
>Check if you can adjust data types/function prototypes.
>Lots of the signed stuff was added as a warning fix for Solaris, I'd
>rather drop that than adding casts all over the place. So you also may
>want to check the file history, why certain constructs were added.
>
>

Is there some easy way to check the file history? Downloading a couple
of old kernels just for one file is a bit of a hassle. And I don't run
bk so I can't access that repository (is it even still present after
Linus' move?).

I'll start looking at removing the signed chars.

Rgds
Pierre