Re: [PATCH] Pointer cast warnings in scripts/

Roman Zippel
2005-06-21T12:35:28Z

Hi,

On Tue, 21 Jun 2005, Pierre Ossman wrote:

> GCC 4 checks the signedness of pointer casts and generates a whole bunch
> of warnings for code in scripts/ (which makes heavy use of signed char
> strings).
>
> This patch adds explicit casts.

Just adding explicit all over the place is really the worst solution.
Check if you can adjust data types/function prototypes.
Lots of the signed stuff was added as a warning fix for Solaris, I'd
rather drop that than adding casts all over the place. So you also may
want to check the file history, why certain constructs were added.

bye, Roman