From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: kbuild-devel@lists.sourceforge.net, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Pointer cast warnings in scripts/
Date: Tue, 21 Jun 2005 14:41:29 +0200 [thread overview]
Message-ID: <42B80AF9.2060708@drzeus.cx> (raw)
In-Reply-To: <Pine.LNX.4.61.0506211413570.3728@scrub.home>
Roman Zippel wrote:
>Just adding explicit all over the place is really the worst solution.
>Check if you can adjust data types/function prototypes.
>Lots of the signed stuff was added as a warning fix for Solaris, I'd
>rather drop that than adding casts all over the place. So you also may
>want to check the file history, why certain constructs were added.
>
>
Is there some easy way to check the file history? Downloading a couple
of old kernels just for one file is a bit of a hassle. And I don't run
bk so I can't access that repository (is it even still present after
Linus' move?).
I'll start looking at removing the signed chars.
Rgds
Pierre
next prev parent reply other threads:[~2005-06-21 12:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-21 11:17 [PATCH] Pointer cast warnings in scripts/ Pierre Ossman
2005-06-21 12:06 ` Mikael Pettersson
2005-06-21 12:18 ` Roman Zippel
2005-06-21 12:41 ` Pierre Ossman [this message]
2005-06-21 12:51 ` Roman Zippel
2005-06-21 12:59 ` Pierre Ossman
2005-06-21 13:14 ` Bernd Petrovitsch
2005-06-22 9:21 ` Pierre Ossman
2005-06-22 10:04 ` Bernd Petrovitsch
2005-06-22 11:12 ` Pierre Ossman
2005-06-22 11:25 ` Russell King
2005-06-21 13:20 ` Roman Zippel
2005-06-21 14:06 ` Pierre Ossman
2005-06-21 14:14 ` Roman Zippel
2005-06-21 21:31 ` J.A. Magallon
2005-06-21 14:19 ` J.A. Magallon
2005-06-21 13:25 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42B80AF9.2060708@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox