From: Jeff Garzik <jgarzik@pobox.com>
To: bobl <bobl@turbolinux.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: a trival bug of megaraid in patch 2.6.12-mm1
Date: Tue, 21 Jun 2005 11:05:44 -0400 [thread overview]
Message-ID: <42B82CC8.3020702@pobox.com> (raw)
In-Reply-To: <42B7E5F2.2060409@turbolinux.com>
bobl wrote:
> Hi, Andrew Morton:
>
> In 2.6.12-mm1 patch, there are some lines as follow:
>
> 300379 +static int
> 300380 +megaraid_reset(Scsi_Cmnd *cmd)
> 300381 +{
> 300382 + adapter = (adapter_t *)cmd->device->host->hostdata;
> 300383 + int rc;
> 300384 +
> 300385 + spin_lock_irq(&adapter->lock);
> 300386 + rc = __megaraid_reset(cmd);
> 300387 + spin_unlock_irq(&adapter->lock);
> 300388 +
> 300389 + return rc;
> 300390 +}
>
> I think between line 300381 and 300382 should add follow line:
>
> adapter_t *adapter;
>
> The attachment is the patch, please confirm it.
>
> Best Regards
>
> Bob
>
>
>
> ------------------------------------------------------------------------
>
> diff -purN linux-2.6.12/drivers/scsi/megaraid.c linux-2.6.12.new/drivers/scsi/megaraid.c
> --- linux-2.6.12/drivers/scsi/megaraid.c 2005-06-21 18:49:50.118732304 +0900
> +++ linux-2.6.12.new/drivers/scsi/megaraid.c 2005-06-21 18:57:55.266978560 +0900
> @@ -1975,6 +1975,7 @@ __megaraid_reset(Scsi_Cmnd *cmd)
> static int
> megaraid_reset(Scsi_Cmnd *cmd)
> {
> + adapter_t *adapter;
> adapter = (adapter_t *)cmd->device->host->hostdata;
> int rc;
>
I think this is my screw-up. I'll get the fix in...
Jeff
prev parent reply other threads:[~2005-06-21 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-21 10:03 a trival bug of megaraid in patch 2.6.12-mm1 bobl
2005-06-21 10:20 ` Michael Buesch
2005-06-21 10:40 ` bobl
2005-06-21 15:05 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42B82CC8.3020702@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=bobl@turbolinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox