Re: -mm -> 2.6.13 merge status

Andi Kleen
2005-06-22T01:57:55Z

On Tue, Jun 21, 2005 at 06:38:07PM -0700, Hans Reiser wrote:
> V4 has a mailing list, and a large number of testers who read the code
> and comment on it. V4 has been reviewed and tested much more than V3
> was before merging. Given that we sent it in quite some time ago, your
> suggestion that an additional review by unspecified additional others be
> a requirement for merging seems untimely. Do you see my point of view
> on this?

The point of the merge review is that people who are familiar with the existing
Linux code double check that the way your code interfacts
with the rest of the kernel is sane, does not have obvious bugs and follows the
existing good practice.

Once the code is in mainline it will get maintained and fixed when needed,
but to make this possible without undue work on the mainline hackers it is needed
to do a full review first.

AFAIK reiserfs has not gotten such a full review yet.

Also good reviewers are rare so it is not a good idea to be picky here.

> Unspecified others doing a review, well, who knows, I will surely take
> the time to consider what is said by them though.....
>
> I would prefer to not get reviews from authors of other filesystems who
> prefer their own code, skim through our code without taking the time to
> grok our philosophy and approach in depth, and then complain that our
> code is different from what they chose to write, and think that our
> changing to be like them should be mandated. I will not name names here....

Someone qualified to review a new file system for inclusion will have need necessary
some experience in Linux file systems, and that can be hardly gotten without ever
having touched one. So you will have to live with other file system authors
commenting on your code.

The main philosophy that is of concern here is also the philosophy of the
core VFS and other kernel interfaces.

> Some of the suggestions on our mailing list are great, some reflect a
> lack of 5 years working with our code, perhaps I should feed our mailing
> list into the linux kernel mailing list so that people on the kernel
> mailing list are more aware that we exist and are active?

Nobody doubts that you are active. Just there are doubts that your
code follows the Linux coding standards enough to not be a undue
mainteance burden in mainline. A review with the following changes
could probably fix that.

-Andi