From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Roman Zippel <zippel@linux-m68k.org>,
kbuild-devel@lists.sourceforge.net,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] Fix signed char problem in scripts/kconfig
Date: Wed, 22 Jun 2005 11:03:02 +0200 [thread overview]
Message-ID: <42B92946.3010207@drzeus.cx> (raw)
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
The signed characters in scripts are causing warnings with GCC 4 on
systems with proper string functions (with char*, not signed char* as
parameters). Some could be kept signed but most had to be reverted to
normal chars.
Detailed changelog:
mconf.c:
- buf/bufptr was used in vsprintf() so it couldn't be signed.
confdata.c:
- conf_expand_value() used strchr() and strncat() forcing
"normal" strings.
conf.c:
- line was used with several string functions so it couldn't be
signed.
- strip() uses strlen() so same thing there.
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
[-- Attachment #2: signed-char-kconfig.patch --]
[-- Type: text/x-patch, Size: 1723 bytes --]
Index: linux-wbsd/scripts/kconfig/mconf.c
===================================================================
--- linux-wbsd/scripts/kconfig/mconf.c (revision 153)
+++ linux-wbsd/scripts/kconfig/mconf.c (working copy)
@@ -254,8 +254,8 @@
" USB$ => find all CONFIG_ symbols ending with USB\n"
"\n");
-static signed char buf[4096], *bufptr = buf;
-static signed char input_buf[4096];
+static char buf[4096], *bufptr = buf;
+static char input_buf[4096];
static char filename[PATH_MAX+1] = ".config";
static char *args[1024], **argptr = args;
static int indent;
Index: linux-wbsd/scripts/kconfig/confdata.c
===================================================================
--- linux-wbsd/scripts/kconfig/confdata.c (revision 153)
+++ linux-wbsd/scripts/kconfig/confdata.c (working copy)
@@ -27,10 +27,10 @@
NULL,
};
-static char *conf_expand_value(const signed char *in)
+static char *conf_expand_value(const char *in)
{
struct symbol *sym;
- const signed char *src;
+ const char *src;
static char res_value[SYMBOL_MAXLENGTH];
char *dst, name[SYMBOL_MAXLENGTH];
Index: linux-wbsd/scripts/kconfig/conf.c
===================================================================
--- linux-wbsd/scripts/kconfig/conf.c (revision 153)
+++ linux-wbsd/scripts/kconfig/conf.c (working copy)
@@ -31,14 +31,14 @@
static int indent = 1;
static int valid_stdin = 1;
static int conf_cnt;
-static signed char line[128];
+static char line[128];
static struct menu *rootEntry;
static char nohelp_text[] = N_("Sorry, no help available for this option yet.\n");
-static void strip(signed char *str)
+static void strip(char *str)
{
- signed char *p = str;
+ char *p = str;
int l;
while ((isspace(*p)))
next reply other threads:[~2005-06-22 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-22 9:03 Pierre Ossman [this message]
2005-06-22 14:44 ` [PATCH 2/2] Fix signed char problem in scripts/kconfig Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42B92946.3010207@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=kbuild-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox