From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263011AbVFWSnu (ORCPT ); Thu, 23 Jun 2005 14:43:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263030AbVFWSjt (ORCPT ); Thu, 23 Jun 2005 14:39:49 -0400 Received: from locomotive.csh.rit.edu ([129.21.60.149]:10785 "EHLO locomotive.unixthugs.org") by vger.kernel.org with ESMTP id S263032AbVFWShI (ORCPT ); Thu, 23 Jun 2005 14:37:08 -0400 Message-ID: <42BB0151.3030904@suse.de> Date: Thu, 23 Jun 2005 14:37:05 -0400 From: Jeff Mahoney User-Agent: Mozilla Thunderbird 1.0 (X11/20041207) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Pekka Enberg Cc: Hans Reiser , Andi Kleen , Alexander Lyamin aka FLX , Alexander Zarochentcev , vs , Andrew Morton , linux-kernel@vger.kernel.org, ReiserFS List , Pekka Enberg Subject: Re: -mm -> 2.6.13 merge status References: <20050620235458.5b437274.akpm@osdl.org.suse.lists.linux.kernel> <42B86027.3090001@namesys.com> <20050621195642.GD14251@wotan.suse.de> <42B8C0FF.2010800@namesys.com> <84144f0205062223226d560e41@mail.gmail.com> In-Reply-To: <84144f0205062223226d560e41@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Pekka Enberg wrote: >>--- /dev/null 2003-09-23 21:59:22.000000000 +0400 >>+++ linux-2.6.11-vs/fs/reiser4/pool.c 2005-06-03 17:49:38.668204642 +0400 >>+/* initialise new pool */ >>+reiser4_internal void >>+reiser4_init_pool(reiser4_pool * pool /* pool to initialise */ , >>+ size_t obj_size /* size of objects in @pool */ , >>+ int num_of_objs /* number of preallocated objects */ , >>+ char *data /* area for preallocated objects */ ) >>+{ >>+ reiser4_pool_header *h; >>+ int i; >>+ >>+ assert("nikita-955", pool != NULL); > > These assertion codes are meaningless to the rest of us so please drop > them. As someone who spends time debugging reiser3 issues, I've grown accustomed to the named assertions. They make discussing a particular assertion much more natural in conversation than file:line. It also makes difficult to reproduce assertions more trackable over time. The assertion number never changes, but the line number can with even the most trivial of patches. That said, one of my gripes with the named assertions in reiser3 (and reiser4 now) is that the development staff changes over time. There are many named assertions in reiser3 that refer to developers no longer employed by Hans. The quoted one is a perfect example. Hans, would it be acceptable to you to keep only numbered assertions and keep a code responsbility list internal to namesys? It would serve a dual purpose of keeping the idea of named assertions, but also remove a huge number of strings that bloat the implementation. -Jeff -- Jeff Mahoney SuSE Labs