Re: Problem compiling 2.6.12

Re: Problem compiling 2.6.12

[Sid Boyce]

George R. Kasica wrote:
> Sid:
> 
> That seems to have got it!!
> 
> Any kernel tuning or optimizations you'd care to recommend?
> 
I've tried a few from time to time, but nothing permanent. I can't 
off-hand remember them, but a google search turns up some options.

> In the future what do I do here or will this continue to work?
> 
As a permanent solution, as suggested in my other email, copying the 
stuff from /usr/include/{linux, asm, asm-generic} to /usr/local/include/ 
seems preferable to making symlinks for every new kernel.

> Thank you SO much, now I remember why I like linux. Helpful people
> like yourself.
> 
> 
> George
> 
> 
As a friend often says, "One hand washes the other", a maxim never more 
true or apt than when applied to Linux and opensource in general.
Regards
Sid.

> 
>>On Sat, 25 Jun 2005 01:06:09 +0100, you wrote:
> 
> 
>>George Kasica wrote:
>>
>>>>Try "ln -s /usr/src/linux-2.6.12/include/linux /usr/local/include" and 
>>>>"ln -s /usr/src/linux-2.6.12/include/asm /usr/local/include", see if 
>>>>it resolves the problem, I expect it will find them. If you still have 
>>>>problems, try "rm /usr/local/include/asm" and "ln -s 
>>>>/usr/src/linux-2.6.12/include/asm-i386 /usr/local/include/asm".
>>>
>>>
>>>Here are the links in /usr/local/include:
>>>
>>>lrwxrwxrwx    1 root     root           35 Jun 24 12:55 asm -> 
>>>/usr/src/linux-2.6.12/include/linux
>>>lrwxrwxrwx    1 root     root           35 Jun 24 12:55 asm-i386 -> 
>>>/usr/src/linux-2.6.12/include/linux
>>>lrwxrwxrwx    1 root     root           35 Jun 24 12:56 linux -> 
>>>/usr/src/linux-2.6.12/include/linux
>>>
>>>
>>>Well, it got further with the links as shown here:
>>>
>>># cd /usr/src/linux-2.6.12.1
>>># make oldconfig
>>>  HOSTCC  scripts/basic/split-include
>>>  HOSTCC  scripts/basic/docproc
>>>  SHIPPED scripts/kconfig/zconf.tab.h
>>>  HOSTCC  scripts/kconfig/conf.o
>>>  HOSTCC  scripts/kconfig/kxgettext.o
>>>  HOSTCC  scripts/kconfig/mconf.o
>>>scripts/kconfig/mconf.c: In function `exec_conf':
>>>scripts/kconfig/mconf.c:486: `EINTR' undeclared (first use in this 
>>>function)
>>>scripts/kconfig/mconf.c:486: (Each undeclared identifier is reported 
>>>only once
>>>scripts/kconfig/mconf.c:486: for each function it appears in.)
>>>scripts/kconfig/mconf.c:486: `EAGAIN' undeclared (first use in this 
>>>function)
>>>make[1]: *** [scripts/kconfig/mconf.o] Error 1
>>>make: *** [oldconfig] Error 2
>>>
>>>But still no joy.
>>>
>>>What now?
>>>
>>>George
>>>
>>>
>>>
>>
>>OK, "ln -s /usr/src/linux-2.6.12.1/include/asm-generic /usr/include".
>>Regards
>>Sid.
> 
> 
> 
> 


-- 
Sid Boyce ... Hamradio License G3VBV, Keen licensed Private Pilot
Retired IBM Mainframes and Sun Servers Tech Support Specialist
Microsoft Windows Free Zone - Linux used for all Computing Tasks

RE: Problem compiling 2.6.12

[Sid Boyce]

Is /usr/src/linux a symlink to linux-2.6.12 .... "ls -ld linux" shows that.
"which gcc" would tell if /usr/local/bin/gcc is being used.
"gcc -v" to show the version.
Something looks confused, the above would be helpful.
Regards
Sid.
-- 
Sid Boyce ... Hamradio License G3VBV, Keen licensed Private Pilot
Retired IBM Mainframes and Sun Servers Tech Support Specialist
Microsoft Windows Free Zone - Linux used for all Computing Tasks

Re: Problem compiling 2.6.12

[Nick Warne]

George Kasica wrote:

> Tried that here and got not much farther...here's the error:
> 
> [root@eagle linux]# make bzImage
>    CHK     include/linux/version.h
>    SPLIT   include/linux/autoconf.h -> include/config/*
>    HOSTCC  scripts/mod/sumversion.o
> In file included from /usr/include/linux/errno.h:4,

That last line looks wrong...  I think you may have symlinks linking to other 
older kernel header stuff.

Easy way to test is untar the Linux.2.6.12 to a totally new location 
(say /home/~/tmp/) and try a build with just the default config.

Nick
-- 
"When you're chewing on life's gristle,
Don't grumble, Give a whistle..."

Re: Problem compiling 2.6.12

[Adrian Bunk]

On Wed, Jun 22, 2005 at 08:37:17PM +0100, Nick Warne wrote:
> George Kasica wrote:
> 
> > Tried that here and got not much farther...here's the error:
> > 
> > [root@eagle linux]# make bzImage
> >    CHK     include/linux/version.h
> >    SPLIT   include/linux/autoconf.h -> include/config/*
> >    HOSTCC  scripts/mod/sumversion.o
> > In file included from /usr/include/linux/errno.h:4,
> 
> That last line looks wrong...  I think you may have symlinks linking to other 
> older kernel header stuff.
>...

No, it looks correct.

That's the copy of linux/errno.h shipped with glibc and that's correct 
when using HOSTCC.

The problem seems to be the /usr/local/ stuff.

> Nick

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: Problem compiling 2.6.12

[Nick Warne]

On Wednesday 22 June 2005 22:30, Adrian Bunk wrote:
> On Wed, Jun 22, 2005 at 08:37:17PM +0100, Nick Warne wrote:
> > George Kasica wrote:
> > > Tried that here and got not much farther...here's the error:
> > >
> > > [root@eagle linux]# make bzImage
> > >    CHK     include/linux/version.h
> > >    SPLIT   include/linux/autoconf.h -> include/config/*
> > >    HOSTCC  scripts/mod/sumversion.o
> > > In file included from /usr/include/linux/errno.h:4,
> >
> > That last line looks wrong...  I think you may have symlinks linking to
> > other older kernel header stuff.
> >...
>
> No, it looks correct.
>
> That's the copy of linux/errno.h shipped with glibc and that's correct
> when using HOSTCC.

Is it?  I thought kernel didn't care what Glibc or what kernel headers you had 
(that is system requirement) - it is automous.  Isn't HOSTCC explicitly just 
what compiler you have?

I build regular in other places... my latest builds are on /mnt/hdb/

Nick
-- 
"When you're chewing on life's gristle,
Don't grumble, Give a whistle..."

Re: Problem compiling 2.6.12

[Adrian Bunk]

On Wed, Jun 22, 2005 at 10:53:47PM +0100, Nick Warne wrote:
> On Wednesday 22 June 2005 22:30, Adrian Bunk wrote:
> > On Wed, Jun 22, 2005 at 08:37:17PM +0100, Nick Warne wrote:
> > > George Kasica wrote:
> > > > Tried that here and got not much farther...here's the error:
> > > >
> > > > [root@eagle linux]# make bzImage
> > > >    CHK     include/linux/version.h
> > > >    SPLIT   include/linux/autoconf.h -> include/config/*
> > > >    HOSTCC  scripts/mod/sumversion.o
> > > > In file included from /usr/include/linux/errno.h:4,
> > >
> > > That last line looks wrong...  I think you may have symlinks linking to
> > > other older kernel header stuff.
> > >...
> >
> > No, it looks correct.
> >
> > That's the copy of linux/errno.h shipped with glibc and that's correct
> > when using HOSTCC.
> 
> Is it?  I thought kernel didn't care what Glibc or what kernel headers you had 
> (that is system requirement) - it is automous.  Isn't HOSTCC explicitly just 
> what compiler you have?
>...

CC is the compiler to actually compile the kernel for the target 
platform.

HOSTCC is the compiler to build helper programs for kernel compilation.

The helper programs HOSTCC compiles aren't part of the kernel, they are 
ordinary userspace programs that could have as well been written in 
Perl.

> Nick

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: Problem compiling 2.6.12

[Nix]

On 22 Jun 2005, Nick Warne stipulated:
> Is it?  I thought kernel didn't care what Glibc or what kernel headers you had 
> (that is system requirement) - it is automous.  Isn't HOSTCC explicitly just 
> what compiler you have?

HOSTCC is a non-cross-compiler, i.e. for building userspace stuff to run
on the build machine. There are a number of such things built during a
normal kernel build (code generators, the config system, et al) and they
use the C library just like any userspace app does.

-- 
`It's as bizarre an intrusion as, I don't know, the hobbits coming home
 to find that the Shire has been taken over by gangsta rappers.'

Problem compiling 2.6.12

[George Kasica]

Hello:

Trying to compile 2.6.12 here and am getting the following error. I am 
currently running 2.4.31 and have upgraded the needed bits per the Change 
document before trying the build:

[root@eagle src]# cd linux
[root@eagle linux]# make mrproper
   CLEAN   .config
[root@eagle linux]# cp ../config-2.4.31 .config
[root@eagle linux]# make oldconfig
   HOSTCC  scripts/basic/fixdep
In file included from /usr/local/include/netinet/in.h:212,
                  from /usr/local/include/arpa/inet.h:23,
                  from scripts/basic/fixdep.c:115:
/usr/local/include/bits/socket.h:304: asm/socket.h: No such file or 
directory
make[1]: *** [scripts/basic/fixdep] Error 1
make: *** [scripts_basic] Error 2

Any help is appreciated, 2.4.31 will compile just fine and I am trying 
make oldconfig with 2.6.12

George
georgek@netwrx1.com

Re: Problem compiling 2.6.12

[Jesper Juhl]

On 6/22/05, George Kasica <georgek@netwrx1.com> wrote:
> Hello:
> 
> Trying to compile 2.6.12 here and am getting the following error. I am
> currently running 2.4.31 and have upgraded the needed bits per the Change
> document before trying the build:
> 
> [root@eagle src]# cd linux
> [root@eagle linux]# make mrproper
>    CLEAN   .config
> [root@eagle linux]# cp ../config-2.4.31 .config
> [root@eagle linux]# make oldconfig

Don't use a 2.4.x config as the basis for a 2.6.x kernel .
Build your first 2.6.x kernel config using "make menuconfig", "make
config", make xconfig" or similar, /then/ you can use that config in
the future as a base for other 2.6.x kernels with "make oldconfig".

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: Problem compiling 2.6.12

[Adrian Bunk]

On Wed, Jun 22, 2005 at 05:59:45PM +0200, Jesper Juhl wrote:
> 
> Don't use a 2.4.x config as the basis for a 2.6.x kernel .
> Build your first 2.6.x kernel config using "make menuconfig", "make
> config", make xconfig" or similar, /then/ you can use that config in
> the future as a base for other 2.6.x kernels with "make oldconfig".

First of all, this shouldn't result in problems like the one he 
reported (see my other mail).

And I'm surprised you are saying this. I'd have expected that running 
"make oldconfig" with a 2.4 kernel should give him a working 
configuration.

Can you explain where you'd expect problems so that we can fix them?

> Jesper Juhl <jesper.juhl@gmail.com>

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: Problem compiling 2.6.12

[George Kasica]

Adrian:

I tried the new 2.6.12 config as suggested by Jesper earlier and got this 
asa result(Not much better):

[root@eagle linux]# make bzImage
   CHK     include/linux/version.h
   SPLIT   include/linux/autoconf.h -> include/config/*
   HOSTCC  scripts/mod/sumversion.o
In file included from /usr/include/linux/errno.h:4,
                  from /usr/local/include/bits/errno.h:25,
                  from /usr/local/include/errno.h:36,
                  from scripts/mod/sumversion.c:8:
/usr/include/asm/errno.h:4: asm-generic/errno.h: No such file or directory
make[2]: *** [scripts/mod/sumversion.o] Error 1
make[1]: *** [scripts/mod] Error 2
make: *** [scripts] Error 2


George

On Wed, 22 Jun 2005, Adrian Bunk wrote:

> On Wed, Jun 22, 2005 at 05:59:45PM +0200, Jesper Juhl wrote:
>>
>> Don't use a 2.4.x config as the basis for a 2.6.x kernel .
>> Build your first 2.6.x kernel config using "make menuconfig", "make
>> config", make xconfig" or similar, /then/ you can use that config in
>> the future as a base for other 2.6.x kernels with "make oldconfig".
>
> First of all, this shouldn't result in problems like the one he
> reported (see my other mail).
>
> And I'm surprised you are saying this. I'd have expected that running
> "make oldconfig" with a 2.4 kernel should give him a working
> configuration.
>
> Can you explain where you'd expect problems so that we can fix them?
>
>> Jesper Juhl <jesper.juhl@gmail.com>
>
> cu
> Adrian
>
> -- 
>
>       "Is there not promise of rain?" Ling Tan asked suddenly out
>        of the darkness. There had been need of rain for many days.
>       "Only a promise," Lao Er said.
>                                       Pearl S. Buck - Dragon Seed
>
>

Re: Problem compiling 2.6.12

[Jesper Juhl]

On 6/22/05, Adrian Bunk <bunk@stusta.de> wrote:
> On Wed, Jun 22, 2005 at 05:59:45PM +0200, Jesper Juhl wrote:
> >
> > Don't use a 2.4.x config as the basis for a 2.6.x kernel .
> > Build your first 2.6.x kernel config using "make menuconfig", "make
> > config", make xconfig" or similar, /then/ you can use that config in
> > the future as a base for other 2.6.x kernels with "make oldconfig".
> 
> First of all, this shouldn't result in problems like the one he
> reported (see my other mail).
> 
> And I'm surprised you are saying this. I'd have expected that running
> "make oldconfig" with a 2.4 kernel should give him a working
> configuration.
> 
> Can you explain where you'd expect problems so that we can fix them?
> 
It's been ages since I personally moved to 2.6, but around the time
when I made the switch I fed several 2.4 configs to oldconfig and the
resulting 2.6 kernels either didn't build properly or they build but
were broken in strange ways. Redoing the 2.6 configs from scratch
always fixed the problems back then. I also encountered similar
reports from people on IRC. Things may have improved since then, but
then again maybe they have not.. I'll see if I can dig out a few of my
old 2.4 configs and retest if there are still issues.

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html

Re: Problem compiling 2.6.12

[George Kasica]

Tried that here and got not much farther...here's the error:

[root@eagle linux]# make bzImage
   CHK     include/linux/version.h
   SPLIT   include/linux/autoconf.h -> include/config/*
   HOSTCC  scripts/mod/sumversion.o
In file included from /usr/include/linux/errno.h:4,
                  from /usr/local/include/bits/errno.h:25,
                  from /usr/local/include/errno.h:36,
                  from scripts/mod/sumversion.c:8:
/usr/include/asm/errno.h:4: asm-generic/errno.h: No such file or directory
make[2]: *** [scripts/mod/sumversion.o] Error 1
make[1]: *** [scripts/mod] Error 2
make: *** [scripts] Error 2


On Wed, 22 Jun 2005, Jesper Juhl wrote:

> On 6/22/05, George Kasica <georgek@netwrx1.com> wrote:
>> Hello:
>>
>> Trying to compile 2.6.12 here and am getting the following error. I am
>> currently running 2.4.31 and have upgraded the needed bits per the Change
>> document before trying the build:
>>
>> [root@eagle src]# cd linux
>> [root@eagle linux]# make mrproper
>>    CLEAN   .config
>> [root@eagle linux]# cp ../config-2.4.31 .config
>> [root@eagle linux]# make oldconfig
>
> Don't use a 2.4.x config as the basis for a 2.6.x kernel .
> Build your first 2.6.x kernel config using "make menuconfig", "make
> config", make xconfig" or similar, /then/ you can use that config in
> the future as a base for other 2.6.x kernels with "make oldconfig".
>
> -- 
> Jesper Juhl <jesper.juhl@gmail.com>
> Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
> Plain text mails only, please      http://www.expita.com/nomime.html
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: Problem compiling 2.6.12

[Richard B. Johnson]

On Wed, 22 Jun 2005, George Kasica wrote:

> Tried that here and got not much farther...here's the error:
>

So how does a kernel compile end up accessing:

> In file included from /usr/include/linux/errno.h:4,
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

In /usr/src there used to be a simlink called /usr/src/linux. It
was a link to /usr/src/linux-`uname -r`. This was also sim-linked
to /usr/include/linux.  There is a possibility that if you
renamed your new /usr/src-linux-2.6.12 to /usr/src/linux, it
overwrote the headers that your 'C' library was compiled with.

After that, all bets are off. To fix, remove the link, /usr/include/linux
and link it to where it used to be as:

 	ln -sf /usr/src/linux-2.4.31/include/linux /usr/include/linux
 	ln -sf /usr/src/linux-2.4.31/include/asm   /usr/include/asm

That should permanently isolate your old 'C' runtime library
include files from new kernel headers.

Then don't use anything called /usr/src/linux. Use the complete
name like /usr/src/linux-2.6.12. That way, these things don't
happen.



> [root@eagle linux]# make bzImage
>   CHK     include/linux/version.h
>   SPLIT   include/linux/autoconf.h -> include/config/*
>   HOSTCC  scripts/mod/sumversion.o
> In file included from /usr/include/linux/errno.h:4,
>                  from /usr/local/include/bits/errno.h:25,
>                  from /usr/local/include/errno.h:36,
>                  from scripts/mod/sumversion.c:8:
> /usr/include/asm/errno.h:4: asm-generic/errno.h: No such file or directory
> make[2]: *** [scripts/mod/sumversion.o] Error 1
> make[1]: *** [scripts/mod] Error 2
> make: *** [scripts] Error 2
>
>
> On Wed, 22 Jun 2005, Jesper Juhl wrote:
>
>> On 6/22/05, George Kasica <georgek@netwrx1.com> wrote:
>>> Hello:
>>>
>>> Trying to compile 2.6.12 here and am getting the following error. I am
>>> currently running 2.4.31 and have upgraded the needed bits per the Change
>>> document before trying the build:
>>>
>>> [root@eagle src]# cd linux
>>> [root@eagle linux]# make mrproper
>>>    CLEAN   .config
>>> [root@eagle linux]# cp ../config-2.4.31 .config
>>> [root@eagle linux]# make oldconfig
>>
>> Don't use a 2.4.x config as the basis for a 2.6.x kernel .
>> Build your first 2.6.x kernel config using "make menuconfig", "make
>> config", make xconfig" or similar, /then/ you can use that config in
>> the future as a base for other 2.6.x kernels with "make oldconfig".
>>
>> --
>> Jesper Juhl <jesper.juhl@gmail.com>
>> Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
>> Plain text mails only, please      http://www.expita.com/nomime.html
>> -
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Cheers,
Dick Johnson
Penguin : Linux version 2.6.12 on an i686 machine (5537.79 BogoMips).
  Notice : All mail here is now cached for review by Dictator Bush.
                  98.36% of all statistics are fiction.

Re: Problem compiling 2.6.12

[Adrian Bunk]

On Wed, Jun 22, 2005 at 10:28:25AM -0500, George Kasica wrote:
> Hello:
> 
> Trying to compile 2.6.12 here and am getting the following error. I am 
> currently running 2.4.31 and have upgraded the needed bits per the Change 
> document before trying the build:
> 
> [root@eagle src]# cd linux
> [root@eagle linux]# make mrproper
>   CLEAN   .config
> [root@eagle linux]# cp ../config-2.4.31 .config
> [root@eagle linux]# make oldconfig
>   HOSTCC  scripts/basic/fixdep
> In file included from /usr/local/include/netinet/in.h:212,
>...

What are these kernel headers under /usr/local ?
I don't see any reason why they should be there.

> George

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: Problem compiling 2.6.12

[George Kasica]

I have no idea what you are referring to there. If you can give me details 
on what information you need or what you need me to do here I'll try to 
provide it. I'm unfortunately not a kernel hacker or programmer here.

George

> On Wed, Jun 22, 2005 at 10:28:25AM -0500, George Kasica wrote:
>> Hello:
>>
>> Trying to compile 2.6.12 here and am getting the following error. I am
>> currently running 2.4.31 and have upgraded the needed bits per the Change
>> document before trying the build:
>>
>> [root@eagle src]# cd linux
>> [root@eagle linux]# make mrproper
>>   CLEAN   .config
>> [root@eagle linux]# cp ../config-2.4.31 .config
>> [root@eagle linux]# make oldconfig
>>   HOSTCC  scripts/basic/fixdep
>> In file included from /usr/local/include/netinet/in.h:212,
>> ...
>
> What are these kernel headers under /usr/local ?
> I don't see any reason why they should be there.
>
>> George
>
> cu
> Adrian

Re: Problem compiling 2.6.12

[Adrian Bunk]

On Wed, Jun 22, 2005 at 02:22:10PM -0500, George Kasica wrote:

> I have no idea what you are referring to there. If you can give me details 
> on what information you need or what you need me to do here I'll try to 
> provide it. I'm unfortunately not a kernel hacker or programmer here.

Where does /usr/local/include/ come from, what is it linked to,... ???

/usr/include contains a copy of kernel headers shipped by your glibc.

/path/to/your/kernel/sources/include contains a copy of kernel headers 
shipped with the kernel you are trying to compile.

But where do these kernel headers under /usr/local/include/ come from?

> George
> 
> >On Wed, Jun 22, 2005 at 10:28:25AM -0500, George Kasica wrote:
> >>Hello:
> >>
> >>Trying to compile 2.6.12 here and am getting the following error. I am
> >>currently running 2.4.31 and have upgraded the needed bits per the Change
> >>document before trying the build:
> >>
> >>[root@eagle src]# cd linux
> >>[root@eagle linux]# make mrproper
> >>  CLEAN   .config
> >>[root@eagle linux]# cp ../config-2.4.31 .config
> >>[root@eagle linux]# make oldconfig
> >>  HOSTCC  scripts/basic/fixdep
> >>In file included from /usr/local/include/netinet/in.h:212,
> >>...
> >
> >What are these kernel headers under /usr/local ?
> >I don't see any reason why they should be there.
> >
> >>George
> >
> >cu
> >Adrian

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed