From: Brian Gerst <bgerst@didntduck.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Doug Warzecha <Douglas_Warzecha@dell.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
abhay_salunke@dell.com, matt_domsch@dell.com
Subject: Re: [PATCH][RFC 2] char: Add Dell Systems Management Base driver
Date: Sun, 26 Jun 2005 21:53:32 -0400 [thread overview]
Message-ID: <42BF5C1C.9080409@didntduck.org> (raw)
In-Reply-To: <1119832167.28649.55.camel@localhost.localdomain>
Alan Cox wrote:
>>+
>>+ /* generate SMI */
>>+ asm("outb %b0,%w1" : :
>>+ "a" (ci_cmd->command_code),
>>+ "d" (ci_cmd->command_address),
>>+ "b" (command_buffer_phys_addr),
>>+ "c" (ci_cmd->signature));
>>+
>
>
> Is there a reason this bit is asm not an outb() macro. If its needed in
> asm for the SMI behaviour then document that fact so nobody "optimises"
> it.
>
Because it has to load values into %ebx and %ecx for the SMI call. The
macro doesn't allow for that.
--
Brian Gerst
next prev parent reply other threads:[~2005-06-27 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-26 23:05 [PATCH][RFC 2] char: Add Dell Systems Management Base driver Doug Warzecha
2005-06-27 0:29 ` Alan Cox
2005-06-27 1:53 ` Brian Gerst [this message]
2005-06-27 3:10 ` randy_dunlap
2005-06-27 20:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42BF5C1C.9080409@didntduck.org \
--to=bgerst@didntduck.org \
--cc=Douglas_Warzecha@dell.com \
--cc=abhay_salunke@dell.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=matt_domsch@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox