From: Michael Krufky <mkrufky@m1k.net>
To: Dave Jones <davej@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: fix silly config option.
Date: Mon, 27 Jun 2005 15:03:30 -0400 [thread overview]
Message-ID: <42C04D82.9000108@m1k.net> (raw)
In-Reply-To: <20050627053928.GA9759@redhat.com>
Dave Jones wrote:
>CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the
>author meant to create.
>
>Signed-off-by: Dave Jones <davej@redhat.com>
>
>--- linux-2.6.12/drivers/media/video/Kconfig~ 2005-06-27 01:37:39.000000000 -0400
>+++ linux-2.6.12/drivers/media/video/Kconfig 2005-06-27 01:37:56.000000000 -0400
>@@ -7,7 +7,7 @@ menu "Video For Linux"
>
> comment "Video Adapters"
>
>-config CONFIG_TUNER_MULTI_I2C
>+config TUNER_MULTI_I2C
> bool "Enable support for multiple I2C devices on Video Adapters (EXPERIMENTAL)"
> depends on VIDEO_DEV && EXPERIMENTAL
> ---help---
>
>
Dave-
If you do:
grep TUNER_MULTI_I2C < patch-2.6.12-git9
you will get:
+config CONFIG_TUNER_MULTI_I2C
+#define CONFIG_TUNER_MULTI_I2C /**/
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifndef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
... So in fact, after applying your patch above, NOW it is a silly
config option, which in effect, removed all functionality of
CONFIG_TUNER_MULTI_I2C alltogether. It so happens that this has been
completely removed in the current -mm, and I've confirmed with Mauro
Chehab (video4linux maintainer) that nothing will be broken after
applying your patch, so there is nothing to worry about. After the
current tuner patches in -mm get merged, this whole thing will be a moot
point.
--
Michael Krufky
next prev parent reply other threads:[~2005-06-27 19:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-27 5:39 fix silly config option Dave Jones
2005-06-27 11:21 ` Adrian Bunk
2005-06-27 15:02 ` Dave Jones
2005-06-27 19:03 ` Michael Krufky [this message]
2005-06-27 19:07 ` Dave Jones
2005-06-27 19:09 ` Michael Krufky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42C04D82.9000108@m1k.net \
--to=mkrufky@m1k.net \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox