fix silly config option.

fix silly config option.

[Dave Jones]

CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the
author meant to create.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.12/drivers/media/video/Kconfig~	2005-06-27 01:37:39.000000000 -0400
+++ linux-2.6.12/drivers/media/video/Kconfig	2005-06-27 01:37:56.000000000 -0400
@@ -7,7 +7,7 @@ menu "Video For Linux"
 
 comment "Video Adapters"
 
-config CONFIG_TUNER_MULTI_I2C
+config TUNER_MULTI_I2C
 	bool "Enable support for multiple I2C devices on Video Adapters (EXPERIMENTAL)"
 	depends on VIDEO_DEV && EXPERIMENTAL
 	---help---

Re: fix silly config option.

[Adrian Bunk]

On Mon, Jun 27, 2005 at 01:39:28AM -0400, Dave Jones wrote:

> CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the
> author meant to create.
>...

I can't find this option.

Which kernel is this patch against?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: fix silly config option.

[Dave Jones]

On Mon, Jun 27, 2005 at 01:21:20PM +0200, Adrian Bunk wrote:
 > On Mon, Jun 27, 2005 at 01:39:28AM -0400, Dave Jones wrote:
 > 
 > > CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the
 > > author meant to create.
 > >...
 > 
 > I can't find this option.
 > 
 > Which kernel is this patch against?
 
2.6.12-git8 (git9 also needs it)

		Dave

Re: fix silly config option.

[Michael Krufky]

Dave Jones wrote:

>CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the
>author meant to create.
>
>Signed-off-by: Dave Jones <davej@redhat.com>
>
>--- linux-2.6.12/drivers/media/video/Kconfig~	2005-06-27 01:37:39.000000000 -0400
>+++ linux-2.6.12/drivers/media/video/Kconfig	2005-06-27 01:37:56.000000000 -0400
>@@ -7,7 +7,7 @@ menu "Video For Linux"
> 
> comment "Video Adapters"
> 
>-config CONFIG_TUNER_MULTI_I2C
>+config TUNER_MULTI_I2C
> 	bool "Enable support for multiple I2C devices on Video Adapters (EXPERIMENTAL)"
> 	depends on VIDEO_DEV && EXPERIMENTAL
> 	---help---
>  
>
Dave-

If you do:

grep TUNER_MULTI_I2C < patch-2.6.12-git9

you will get:

+config CONFIG_TUNER_MULTI_I2C
+#define CONFIG_TUNER_MULTI_I2C /**/
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifndef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C

... So in fact, after applying your patch above,  NOW it is a silly 
config option, which in effect, removed all functionality of 
CONFIG_TUNER_MULTI_I2C alltogether.  It so happens that this has been 
completely removed in the current -mm, and I've confirmed with Mauro 
Chehab (video4linux maintainer) that nothing will be broken after 
applying your patch, so there is nothing to worry about.  After the 
current tuner patches in -mm get merged, this whole thing will be a moot 
point.

-- 
Michael Krufky

Re: fix silly config option.

[Dave Jones]

On Mon, Jun 27, 2005 at 03:03:30PM -0400, Michael Krufky wrote:

 > +config CONFIG_TUNER_MULTI_I2C
 > +#define CONFIG_TUNER_MULTI_I2C /**/
 > +#ifdef CONFIG_TUNER_MULTI_I2C
 > +#ifdef CONFIG_TUNER_MULTI_I2C
 > +#ifdef CONFIG_TUNER_MULTI_I2C
 > +#ifndef CONFIG_TUNER_MULTI_I2C
 > +#ifdef CONFIG_TUNER_MULTI_I2C
 > 
 > ... So in fact, after applying your patch above,  NOW it is a silly 
 > config option, which in effect, removed all functionality of 
 > CONFIG_TUNER_MULTI_I2C alltogether

Err, no. Note how no other config options have CONFIG_ prepended
to them. Kconfig magic does this for you implicitly.

		Dave

 

Re: fix silly config option.

[Michael Krufky]

Dave Jones wrote:

>On Mon, Jun 27, 2005 at 03:03:30PM -0400, Michael Krufky wrote:
>
> > +config CONFIG_TUNER_MULTI_I2C
> > +#define CONFIG_TUNER_MULTI_I2C /**/
> > +#ifdef CONFIG_TUNER_MULTI_I2C
> > +#ifdef CONFIG_TUNER_MULTI_I2C
> > +#ifdef CONFIG_TUNER_MULTI_I2C
> > +#ifndef CONFIG_TUNER_MULTI_I2C
> > +#ifdef CONFIG_TUNER_MULTI_I2C
> > 
> > ... So in fact, after applying your patch above,  NOW it is a silly 
> > config option, which in effect, removed all functionality of 
> > CONFIG_TUNER_MULTI_I2C alltogether
>
>Err, no. Note how no other config options have CONFIG_ prepended
>to them. Kconfig magic does this for you implicitly.
>
OOPS!  I stand corrected.  :-)

-- 
Michael Krufky