Re: 2.6.12 breaks 8139cp

Jeff Garzik
2005-06-25T03:16:52Z

Ed Sweetman wrote:
> Sorry, i'm retarded, i pasted the wrong changelog line.
>
> <hch@lst.de>
> [8139TOO]: Use rtnl_lock_interruptible()
>
> The 8139too thread needs to use rtnl_lock_interruptible so it can avoid
> doing the actual work once it's been kill_proc()ed on module removal
> time.
>
> Based on debugging and an earlier patch that adds a driver-private
> semaphore from Herbert Xu.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> This seems to be the only patch that contains a change to the 8139too
> code between working and non-working code.

Please verify that reverting this patch actually fixed your problem.

$subject talks about 8139cp, but you list a change to 8139too, which are
two different drivers.

It's often wrong to focus on the driver. If a driver suddenly stops
working, that may indicate a problem in the interrupt subsystem, etc.

Jeff