From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262228AbVF2IZv (ORCPT ); Wed, 29 Jun 2005 04:25:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262237AbVF2IZu (ORCPT ); Wed, 29 Jun 2005 04:25:50 -0400 Received: from s0003.shadowconnect.net ([213.239.201.226]:46607 "EHLO mail.shadowconnect.com") by vger.kernel.org with ESMTP id S262228AbVF2IYv (ORCPT ); Wed, 29 Jun 2005 04:24:51 -0400 Message-ID: <42C25CBF.8000509@shadowconnect.com> Date: Wed, 29 Jun 2005 10:33:03 +0200 From: Markus Lidel User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Greg KH CC: Christoph Hellwig , linux-kernel@vger.kernel.org Subject: Re: sysfs abuse in recent i2o changes References: <20050628112102.GA1111@lst.de> <42C16691.3090205@shadowconnect.com> <20050628162125.GA9239@suse.de> <42C19214.6070708@shadowconnect.com> <20050628180719.GA11585@suse.de> In-Reply-To: <20050628180719.GA11585@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hello, Greg KH wrote: > On Tue, Jun 28, 2005 at 08:08:20PM +0200, Markus Lidel wrote: >>Greg KH wrote: >>>On Tue, Jun 28, 2005 at 05:02:41PM +0200, Markus Lidel wrote: >>>>I know, but i hopefully also have a good reason to do so... First, the >>>>attributes provided through these functions are for accessing the >>>>firmware... The controller has a little limitation, it could only handle >>>>64 blocks, but sysfs only have 4k... >>>>Now there are two options: >>>>1) when writing: read a 64k block, merge it with the 4k block and write >>>>it back, when reading: read a 64k block and only return the needed 4k >>>>block. >>>>2) extend the sysfs attribute to allow 64k blocks >>>>IMHO the first is not a very good solution, because for a 64k block it >>>>has to be written 16 times... >>>>Of course if someone finds a better solution i would be glad to hear >>>>about it... >>>Use the binary file interface of sysfs, which was written exactly for >>>this kind of thing. :) >>Oh i tried to use the binary interface, but i haven't found a way to >>increase the block size beyond 4k, could you please tell me how i could >>adjust it, or where i could read about it? > Your code should not care about the block size of the data given to you, > as userspace could be giving you 1 byte at a time. Buffer it up The driver don't care about the block size but the device do... Of course you could send 1 byte at a time, but if you do so the controller blows up... > yourself and then write it out to the device when needed. Yep, but this way there is much more code needed to handle it, and also the memory for the buffer may be used longer then just for the read/write... > But if you are doing this for firmware, then please use the kernel > firmware interface, it does all of the buffering for you. In my case the interface is for updating the firmware and also to access the configuration settings of the controller... The way to retrieve/store the firmware and the configuration settings is the same, so i still have to implement the sysfs attributes for the configuration settings... > Either way, having your own file_ops in sysfs is not allowed. That was the reason i not changed sysfs and only used it in my own module, because i see that it is only needed because of the limitations of the hardware... Thank you very much. Best regards, Markus Lidel ------------------------------------------ Markus Lidel (Senior IT Consultant) Shadow Connect GmbH Carl-Reisch-Weg 12 D-86381 Krumbach Germany Phone: +49 82 82/99 51-0 Fax: +49 82 82/99 51-11 E-Mail: Markus.Lidel@shadowconnect.com URL: http://www.shadowconnect.com