From: Prakash Punnoor <prakash@punnoor.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>, se.witt@gmx.net
Subject: Re: Linux 2.6.13-rc1 - [PATCH] Don't fill up log with atxp1 vcore change message
Date: Wed, 29 Jun 2005 14:13:54 +0200 [thread overview]
Message-ID: <42C29082.8060104@punnoor.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0506282310040.14331@ppc970.osdl.org>
[-- Attachment #1.1: Type: text/plain, Size: 895 bytes --]
Hi,
I am using atxp1 module to change vcore on my NForce2 via userspace daemon
(see punnoor.de). Currently atxp1 module will write to the log on every vcore
change, thus filling up my log - which I don't want. I am no kernel coder, but
I guess, this one-liner will change this behaviour in a wanted way, ie output
will be made for debug purposes only. (Please use the attached patch, if
inlined one got fsked up by TB.)
Cheers,
Prakash
Signed-off-by: Prakash Punnoor <prakash@punnoor.de>
--- drivers/i2c/chips/atxp1.c~ 2005-06-29 13:59:04.000000000 +0200
+++ drivers/i2c/chips/atxp1.c 2005-06-29 13:59:22.164237992 +0200
@@ -144,7 +144,7 @@
if (vid == cvid)
return count;
- dev_info(dev, "Setting VCore to %d mV (0x%02x)\n", vcore, vid);
+ dev_dbg(dev, "Setting VCore to %d mV (0x%02x)\n", vcore, vid);
/* Write every 25 mV step to increase stability */
if (cvid > vid) {
[-- Attachment #1.2: atxp1_debug.diff --]
[-- Type: text/plain, Size: 397 bytes --]
--- drivers/i2c/chips/atxp1.c~ 2005-06-29 13:59:04.000000000 +0200
+++ drivers/i2c/chips/atxp1.c 2005-06-29 13:59:22.164237992 +0200
@@ -144,7 +144,7 @@
if (vid == cvid)
return count;
- dev_info(dev, "Setting VCore to %d mV (0x%02x)\n", vcore, vid);
+ dev_dbg(dev, "Setting VCore to %d mV (0x%02x)\n", vcore, vid);
/* Write every 25 mV step to increase stability */
if (cvid > vid) {
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-06-29 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-29 6:30 Linux 2.6.13-rc1 Linus Torvalds
2005-06-29 7:46 ` Brice Goglin
2005-06-29 9:02 ` Brice Goglin
2005-06-29 9:29 ` William Lee Irwin III
2005-06-29 12:13 ` Prakash Punnoor [this message]
2005-06-29 15:01 ` Linux 2.6.13-rc1 - bad tag in git tree? Dave Kleikamp
2005-06-29 15:28 ` Jeff Garzik
2005-06-29 15:45 ` Linus Torvalds
2005-06-29 19:31 ` Linux 2.6.13-rc1 Jesper Juhl
2005-06-29 21:00 ` David Weinehall
2005-06-29 22:34 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42C29082.8060104@punnoor.de \
--to=prakash@punnoor.de \
--cc=linux-kernel@vger.kernel.org \
--cc=se.witt@gmx.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox