[TRIVIAL PATCH] v4l cx88 hue offset fix

[TRIVIAL PATCH] v4l cx88 hue offset fix

[Michael Krufky]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: trivial-v4l-cx88-video-hue-offset-fix.patch --]
[-- Type: text/plain, Size: 945 bytes --]

  Changed hue offset to 128 to correct behavior in cx88 cards.
  Previously, setting 0% or 100% hue was required to avoid blue/green
  people on screen.  Now, 50% Hue means no offset, just like bt878 stuff.

Signed-off-by: Michael Krufky <mkrufky@m1k.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>

 cx88-video.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -upr a/drivers/media/video/cx88/cx88-video.c b/drivers/media/video/cx88/cx88-video.c
--- a/drivers/media/video/cx88/cx88-video.c	2005-06-29 21:59:40.000000000 -0400
+++ b/drivers/media/video/cx88/cx88-video.c	2005-06-29 21:54:27.000000000 -0400
@@ -268,7 +268,7 @@ static struct cx88_ctrl cx8800_ctls[] = 
 			.default_value = 0,
 			.type          = V4L2_CTRL_TYPE_INTEGER,
 		},
-		.off                   = 0,
+		.off                   = 128,
 		.reg                   = MO_HUE,
 		.mask                  = 0x00ff,
 		.shift                 = 0,

Re: [TRIVIAL PATCH] v4l cx88 hue offset fix

[Mauro Carvalho Chehab]

Michael Krufky wrote:
> 
> 
> ------------------------------------------------------------------------
> 
>   Changed hue offset to 128 to correct behavior in cx88 cards.
>   Previously, setting 0% or 100% hue was required to avoid blue/green
>   people on screen.  Now, 50% Hue means no offset, just like bt878 stuff.
> 
> Signed-off-by: Michael Krufky <mkrufky@m1k.net>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
> 
Acked-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>

	This small patch fixes top complain about CX88 cards, which had a
different behavior than other V4L cards for hue setting.

	It can also be applied also at 2.6.13 mainstream.

[TRIVIAL 2.6.12 / 2.6.13 PATCH] v4l cx88 hue offset fix

[Michael Krufky]

[-- Attachment #1: Type: text/plain, Size: 831 bytes --]

Mauro Carvalho Chehab wrote:

>Acked-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
>
>This small patch fixes top complaint about CX88 cards, which had a
>different behavior than other V4L cards for hue setting.
>
>It can also be applied also at 2.6.13 mainstream.
>
I must add:  Not only does this apply to 2.6.13, but it also applies to 
2.6.12 ... Can we have this put into the patch queue for 2.6.12.3 ?  
This IS a bug fix, and makes a HUGE improvement for cx88 boards.

I'd really like to see this in the mainstream kernel before the livecd 
distros make their next releases.

I would send this to Greg Kroah-Hartman / Chris Wright myself, but I 
don't know if that is proper protocol for doing this.  Andrew, please 
send this to the correct person.

Thank you.

Attached is a diff against 2.6.12.2

-- 
Michael Krufky


[-- Attachment #2: 2.6.12-trivial-v4l-cx88-video-hue-offset-fix.patch --]
[-- Type: text/plain, Size: 976 bytes --]

Changed hue offset to 128 to correct behavior in cx88 cards.  Previously, 
setting 0% or 100% hue was required to avoid blue/green people on screen.  
Now, 50% Hue means no offset, just like bt878 stuff.

Signed-off-by: Michael Krufky <mkrufky@m1k.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>

 cx88-video.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -upr linux-2.6.12.2/drivers/media/video/cx88/cx88-video.c linux/drivers/media/video/cx88/cx88-video.c
--- linux-2.6.12.2/drivers/media/video/cx88/cx88-video.c	2005-06-17 15:48:29.000000000 -0400
+++ linux/drivers/media/video/cx88/cx88-video.c	2005-06-30 11:47:49.000000000 -0400
@@ -261,7 +261,7 @@ static struct cx88_ctrl cx8800_ctls[] = 
 			.default_value = 0,
 			.type          = V4L2_CTRL_TYPE_INTEGER,
 		},
-		.off                   = 0,
+		.off                   = 128,
 		.reg                   = MO_HUE,
 		.mask                  = 0x00ff,
 		.shift                 = 0,

Re: [TRIVIAL 2.6.12 / 2.6.13 PATCH] v4l cx88 hue offset fix

[Jesper Juhl]

On 6/30/05, Michael Krufky <mkrufky@m1k.net> wrote:
> Mauro Carvalho Chehab wrote:
> 
> >Acked-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
> >
> >This small patch fixes top complaint about CX88 cards, which had a
> >different behavior than other V4L cards for hue setting.
> >
[...]
> 
> I would send this to Greg Kroah-Hartman / Chris Wright myself, but I
> don't know if that is proper protocol for doing this.

http://kerneltrap.org/mailarchive/1/message/33322/thread
See the "Procedure for submitting patches to the -stable tree" section
in particular.

(that document really should go into Documentation/ by the way)

-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html