From: Jeff Mahoney <jeffm@suse.com>
To: Jens Axboe <axboe@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] reiserfs: enable attrs by default if saf
Date: Thu, 30 Jun 2005 09:23:31 -0400 [thread overview]
Message-ID: <42C3F253.8060305@suse.com> (raw)
In-Reply-To: <20050630101334.GJ2243@suse.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Doh. Thanks.
- -Jeff
Jens Axboe wrote:
> On Wed, Jun 29 2005, Jeff Mahoney wrote:
>> The following patch enables attrs by default if the reiserfs_attrs_cleared
>> bit is set in the superblock. This allows chattr-type attrs to be used
>> without any further action by the user.
>>
>> Please apply.
>>
>>Signed-off-by: Jeff Mahoney <jeffm@suse.com>
>>
>>diff -ruNpX dontdiff linux-2.6.12-rc6/fs/reiserfs/super.c linux-2.6.12-rc6.devel/fs/reiserfs/super.c
>>--- linux-2.6.12-rc6/fs/reiserfs/super.c 2005-06-13 14:34:58.000000000 -0400
>>+++ linux-2.6.12-rc6.devel/fs/reiserfs/super.c 2005-06-22 17:34:55.000000000 -0400
>>@@ -884,6 +884,8 @@ static void handle_attrs( struct super_b
>> reiserfs_warning(s, "reiserfs: cannot support attributes until flag is set in super-block" );
>> REISERFS_SB(s) -> s_mount_opt &= ~ ( 1 << REISERFS_ATTRS );
>> }
>>+ } else if (le32_to_cpu( rs -> s_flags ) & reiserfs_attrs_cleared) {
>>+ REISERFS_SB(s)->s_mount_opt |= REISERFS_ATTRS;
>> }
>> }
>
> Except rs isn't initialized there, causing a compile warning and a crash
> booting the resulting kernel when reiser mounts...
>
> Signed-off-by: Jens Axboe <axboe@suse.de>
>
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -1053,10 +1053,9 @@ static void handle_barrier_mode(struct s
>
> static void handle_attrs( struct super_block *s )
> {
> - struct reiserfs_super_block * rs;
> + struct reiserfs_super_block * rs = SB_DISK_SUPER_BLOCK (s);
>
> if( reiserfs_attrs( s ) ) {
> - rs = SB_DISK_SUPER_BLOCK (s);
> if( old_format_only(s) ) {
> reiserfs_warning(s, "reiserfs: cannot support attributes on 3.5.x disk format" );
> REISERFS_SB(s) -> s_mount_opt &= ~ ( 1 << REISERFS_ATTRS );
>
- --
Jeff Mahoney
SuSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
iD8DBQFCw/JTLPWxlyuTD7IRAgM4AJ9Z12KyHZqvqeYEM1SySO7Dg/2vWwCfaH7Y
qz/pAeg2gy1JigcIbgbbghA=
=LHPR
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2005-06-30 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-29 22:53 [PATCH] reiserfs: enable attrs by default if saf Jeff Mahoney
2005-06-30 10:13 ` Jens Axboe
2005-06-30 13:23 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42C3F253.8060305@suse.com \
--to=jeffm@suse.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox