public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paulo Marques <pmarques@grupopie.com>
To: Robert Love <rml@novell.com>
Cc: linux-kernel@vger.kernel.org,
	Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
	Andrew Morton <akpm@osdl.org>,
	John McCutchan <ttb@tentacle.dhs.org>
Subject: Re: [patch] latest inotify.
Date: Thu, 30 Jun 2005 14:55:41 +0100	[thread overview]
Message-ID: <42C3F9DD.8080502@grupopie.com> (raw)
In-Reply-To: <1119989024.6745.20.camel@betsy>

Robert Love wrote:
> Below is the latest inotify patch, against 2.6.12.
> 
> [...]
> +/*
> + * fsnotify_oldname_init - save off the old filename before we change it
> + *
> + * XXX: This could be kstrdup if only we could add that to lib/string.c
> + */

I knew you were waiting for this, so I just wanted to let you know that 
the kstrdup function is already available in Linus tree 2.6.13-rc1. It 
is declared linux/string.h and implemented in mm/slab.c.

It is not implemented in lib/string.c because some architectures use lib 
functions in their bootloading code where the allocation functions are 
not available, and the linking stage then fails because of the kmalloc 
reference :P

-- 
Paulo Marques - www.grupopie.com

It is a mistake to think you can solve any major problems
just with potatoes.
Douglas Adams

  parent reply	other threads:[~2005-06-30 13:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-28 20:03 [patch] latest inotify Robert Love
2005-06-28 21:31 ` Grzegorz Kulewski
2005-06-28 21:37   ` Robert Love
2005-06-28 21:39   ` Robert Love
2005-06-28 21:48     ` Grzegorz Kulewski
2005-06-28 21:53       ` Robert Love
2005-06-30 13:55 ` Paulo Marques [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-05-16 19:21 Robert Love
2005-05-21 23:02 ` Will Dyson
2005-04-21  5:13 [patch] inotify for 2.6.12-rc3 Robert Love
2005-04-22  5:01 ` [patch] updated " Robert Love
2005-04-28 20:38   ` [patch] latest inotify Robert Love

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42C3F9DD.8080502@grupopie.com \
    --to=pmarques@grupopie.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rml@novell.com \
    --cc=ttb@tentacle.dhs.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox