public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans Reiser <reiser@namesys.com>
To: Jens Axboe <axboe@suse.de>, Edward Shishkin <edward@namesys.com>
Cc: linux-kernel@vger.kernel.org, reiserfs-list@namesys.com,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] reiser BUG in 2.6.13-rc1
Date: Thu, 30 Jun 2005 10:42:21 -0700	[thread overview]
Message-ID: <42C42EFD.8050306@namesys.com> (raw)
In-Reply-To: <20050630101157.GI2243@suse.de>

Jens Axboe wrote:

>Hi,
>
>Reiser is derefencing an uninitialized pointer, causing an oops on boot.
>
>Signed-off-by: Jens Axboe <axboe@suse.de>
>
>diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
>--- a/fs/reiserfs/super.c
>+++ b/fs/reiserfs/super.c
>@@ -1053,10 +1053,9 @@ static void handle_barrier_mode(struct s
> 
> static void handle_attrs( struct super_block *s )
> {
>-	struct reiserfs_super_block * rs;
>+	struct reiserfs_super_block * rs = SB_DISK_SUPER_BLOCK (s);
> 
> 	if( reiserfs_attrs( s ) ) {
>-		rs = SB_DISK_SUPER_BLOCK (s);
> 		if( old_format_only(s) ) {
> 			reiserfs_warning(s, "reiserfs: cannot support attributes on 3.5.x disk format" );
> 			REISERFS_SB(s) -> s_mount_opt &= ~ ( 1 << REISERFS_ATTRS );
>
>  
>
Thanks Jens.

Edward, how is the fedora boot bug finding going? Is this it by any chance?

Hans

  reply	other threads:[~2005-06-30 17:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-30 10:11 [PATCH] reiser BUG in 2.6.13-rc1 Jens Axboe
2005-06-30 17:42 ` Hans Reiser [this message]
2005-06-30 18:49   ` Edward Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42C42EFD.8050306@namesys.com \
    --to=reiser@namesys.com \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=edward@namesys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=reiserfs-list@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox