public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Prakash Punnoor <prakash@punnoor.de>
To: Sebastian Pigulak <dreamin@interia.pl>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: [PATCH]Re: atxp1 module not compiling; needs I2C_SENSOR
Date: Fri, 01 Jul 2005 00:23:21 +0200	[thread overview]
Message-ID: <42C470D9.6050905@punnoor.de> (raw)
In-Reply-To: <20050630234709.1ad1512a@DreaM.darnet>


[-- Attachment #1.1: Type: text/plain, Size: 1143 bytes --]

Sebastian Pigulak schrieb:
> Hey,
> 
> I've tried patching linux-2.6.13-RC1 with patch-2.6.13-rc1-git2 and building atxp1(it allows Vcore voltage changing) into the kernel. Unfortunately, the kernel compilation stops with:
> 
> LD      init/built-in.o
> LD      vmlinux
> drivers/built-in.o(.text+0x92298): In function `atxp1_detect':
> : undefined reference to `i2c_which_vrm'
> drivers/built-in.o(.text+0x921ae): In function `atxp1_attach_adapter':
> : undefined reference to `i2c_detect'
> make: *** [vmlinux] Błąd 1
> ==> ERROR: Build Failed.  Aborting... 
> 
> Could someone have a look at the module and possibly fix it up?

Try attached patch.  (Works fine for me then.)

Cheers,

Prakash

Signed-off-by: Prakash Punnoor <prakash@punnoor.de>

--- drivers/i2c/chips/Kconfig~	2005-06-29 11:06:01.000000000 +0200
+++ drivers/i2c/chips/Kconfig	2005-07-01 00:17:34.972426160 +0200
@@ -80,6 +80,7 @@
 config SENSORS_ATXP1
 	tristate "Attansic ATXP1 VID controller"
 	depends on I2C && EXPERIMENTAL
+	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Attansic ATXP1 VID
 	  controller.

[-- Attachment #1.2: atxp1_needs_i2c_sensor.diff --]
[-- Type: text/plain, Size: 359 bytes --]

--- drivers/i2c/chips/Kconfig~	2005-06-29 11:06:01.000000000 +0200
+++ drivers/i2c/chips/Kconfig	2005-07-01 00:17:34.972426160 +0200
@@ -80,6 +80,7 @@
 config SENSORS_ATXP1
 	tristate "Attansic ATXP1 VID controller"
 	depends on I2C && EXPERIMENTAL
+	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Attansic ATXP1 VID
 	  controller.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

      parent reply	other threads:[~2005-06-30 22:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-30 21:47 atxp1 module not compiling Sebastian Pigulak
2005-06-30 22:17 ` [2.6 patch] SENSORS_ATXP1 must select I2C_SENSOR Adrian Bunk
2005-06-30 23:01   ` Sebastian Pigulak
2005-07-01 14:41   ` Jean Delvare
2005-06-30 22:23 ` Prakash Punnoor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42C470D9.6050905@punnoor.de \
    --to=prakash@punnoor.de \
    --cc=dreamin@interia.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox