Re: [PATCH 2/2] ISA DMA suspend for x86_64

Andi Kleen
2005-07-02T17:43:01Z

> I used i8259.c as an example and it includes its suspend routines in all
> cases. Also, the problem this patch solves is for suspend-to-ram, not
> suspend-to-disk (i.e. software suspend).

Hmm, it would be better if that all was CONFIG_ able. But ok.

> Index: linux-wbsd/arch/x86_64/kernel/Makefile
> ===================================================================
> --- linux-wbsd/arch/x86_64/kernel/Makefile (revision 153)
> +++ linux-wbsd/arch/x86_64/kernel/Makefile (working copy)
> @@ -7,7 +7,8 @@
> obj-y := process.o semaphore.o signal.o entry.o traps.o irq.o \
> ptrace.o time.o ioport.o ldt.o setup.o i8259.o sys_x86_64.o \
> x8664_ksyms.o i387.o syscall.o vsyscall.o \
> - setup64.o bootflag.o e820.o reboot.o quirks.o
> + setup64.o bootflag.o e820.o reboot.o quirks.o \
> + ../../i386/kernel/i8237.o

I think that will break in builds with separate objdirs. You'll need
to do it like the other files (see the end of the Makefile)

-Andi