Re: [PATCH 2/2] ISA DMA suspend for x86_64

Adam Belay
2005-07-01T19:37:31Z

On Fri, Jul 01, 2005 at 12:53:31PM +0200, Andi Kleen wrote:
> Pierre Ossman <drzeus-list@drzeus.cx> writes:
>
> > Reset the ISA DMA controller into a known state after a suspend. Primary
> > concern was reenabling the cascading DMA channel (4).
> >
> > Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
> >
> > Word of warning, I haven't tested this platform since I don't have any
> > x86_64 hardware. But it shouldn't differ from i386.
>
> This is identical to the i386 version isn't it?
> Please just reuse the i386 version then in the Makefile.
>
> And the whole thing should be probably dependent on CONFIG_SOFTWARE_SUSPEND
>
> -Andi

CONFIG_SOFTWARE_SUSPEND is only suspend-to-disk. There are other power
management states that may need to be included (e.g. ACPI S1-S3).

Thanks,
Adam