From: Stefan Seyfried <seife@suse.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [patch] swsusp: fix error handling
Date: Mon, 04 Jul 2005 08:37:35 +0200 [thread overview]
Message-ID: <42C8D92F.5000501@suse.de> (raw)
In-Reply-To: <20050703215651.GA10766@elf.ucw.cz>
Pavel Machek wrote:
> --- a/kernel/power/swsusp.c
> +++ b/kernel/power/swsusp.c
> @@ -998,14 +991,20 @@ int swsusp_suspend(void)
> * at resume time, and evil weirdness ensues.
> */
> if ((error = device_power_down(PMSG_FREEZE))) {
> - printk(KERN_ERR "Some devices failed to power down, aborting suspend\n");
i don't like this one. Silent failures are a major PITA.
> + printk("Error %d suspending\n", error);
therefor i like this one ;-) Maybe with a printk level?
--
Stefan Seyfried \ "I didn't want to write for pay. I
QA / R&D Team Mobile Devices \ wanted to be paid for what I write."
SUSE LINUX Products GmbH, Nürnberg \ -- Leonard Cohen
prev parent reply other threads:[~2005-07-04 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-03 21:56 [patch] swsusp: fix error handling Pavel Machek
2005-07-04 6:37 ` Stefan Seyfried [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42C8D92F.5000501@suse.de \
--to=seife@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox