Re: [git patches] IDE update

Jeff Garzik
2005-07-05T02:48:58Z

Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> Please pull from:
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/bart/ide-2.6.git
>
> diffstat+changelog below
>
> Bartlomiej
>
>
> drivers/ide/Makefile | 1 -
> drivers/ide/ide-lib.c | 13 +++++--------
> drivers/ide/pci/alim15x3.c | 10 +++++-----
> drivers/ide/pci/amd74xx.c | 7 +++++--
> drivers/ide/pci/cs5530.c | 4 ++--
> drivers/ide/pci/cy82c693.c | 8 ++++----
> drivers/ide/pci/it8172.c | 4 ++--
> drivers/ide/pci/ns87415.c | 2 +-
> drivers/ide/pci/opti621.c | 2 +-
> drivers/ide/pci/sc1200.c | 2 +-
> drivers/ide/pci/sl82c105.c | 6 +++---
> drivers/ide/pci/slc90e66.c | 2 +-
> drivers/ide/pci/triflex.c | 2 +-
> drivers/ide/pci/via82cxxx.c | 4 ++--
> include/linux/pci_ids.h | 1 +
> 15 files changed, 34 insertions(+), 34 deletions(-)

FWIW, we should encourage the janitors to submit patches larger than
simply one patch per file. Spreading the -same- logical change across
multiple patches is really taking the "split it up" mantra too far.

We want logical changes separated... but this just spams the log IMO.

All of the __devinit changes could have been rolled into a single patch,
since its going to a single maintainer (Bart).

Jeff