public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: George Anzinger <george@mvista.com>
To: Andrew Morton <akpm@osdl.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: Build TAGS problem with O=
Date: Tue, 05 Jul 2005 19:51:03 -0700	[thread overview]
Message-ID: <42CB4717.4050609@mvista.com> (raw)
In-Reply-To: <42C5B967.6040908@mvista.com>

George Anzinger wrote:
> If you try:
> make O=/usr/src/ver/2.6.13-rc/obj/ -j5 LOCALVERSION=_2.6.13-rc TAGS 
> ARCH=i386
> 
> it fails with:
>   MAKE   TAGS
> find: security/selinux/include: No such file or directory
> find: include: No such file or directory
> find: include/asm-i386: No such file or directory
> find: include/asm-generic: No such file or directory
> 
> 
> The problem seems to be this bit of the topdir Makefile:
> 
> 
> #We want __srctree to totally vanish out when KBUILD_OUTPUT is not set
> #(which is the most common case IMHO) to avoid unneeded clutter in the 
> big tags file.
> #Adding $(srctree) adds about 20M on i386 to the size of the output file!
> 
> ifeq ($(KBUILD_OUTPUT),)
> __srctree =
> else
> __srctree = $(srctree)/
> endif
> 
> It would appear that the "ifeq ($(KBUILD_OUTPUT),)" is doing the wrong 
> thing.  I am not a make expert, but I have had a lot of BAD experience 
> trying to use this construct.  Any one up to proposing a fix?
> 
The problem appears to be that KBUILD_OUTPUT is NOT defined after make reruns 
itself.  Here is a fix:

Signed-off-by:  George Anzinger  <george@mvista.com>

--- /usr/src/linux-2.6.12-org/Makefile	2005-07-01 14:37:44.000000000 -0700
+++ /usr/src/linux-2.6.13-rc/Makefile	2005-07-05 19:45:00.588314304 -0700
@@ -1149,7 +1149,7 @@
  #(which is the most common case IMHO) to avoid unneeded clutter in the big 
tags file.
  #Adding $(srctree) adds about 20M on i386 to the size of the output file!

-ifeq ($(KBUILD_OUTPUT),)
+ifeq ($(src),$(obj))
  __srctree =
  else
  __srctree = $(srctree)/



-- 
George Anzinger   george@mvista.com
HRT (High-res-timers):  http://sourceforge.net/projects/high-res-timers/

  reply	other threads:[~2005-07-06  5:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-01 21:45 Build TAGS problem with O= George Anzinger
2005-07-06  2:51 ` George Anzinger [this message]
2005-07-06 15:30 ` George Anzinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42CB4717.4050609@mvista.com \
    --to=george@mvista.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox