Re: [PATCH 2.6.13-rc1 03/10] IOCHK interface for I/O error handling/detecting

Hidetoshi Seto
2005-07-13T01:31:40Z

Linas Vepstas wrote:
> Thus, one wouldn't want to perform an iochk_read() in this way unless
> one was already pretty sure that an error had already occured ...

If another kind of I/O error detecting system finds a error before
performing iochk_read(), it can prevents coming iochk_read() from
spending such crazy cycles in have_error() by marking cookie->error.

>> int iochk_read(iocookie *cookie)
>> {
>> + if (cookie->error || have_error(cookie->dev))

Isn't it enough?

And as Ben said, it seems that ppc64 can have its own special iochk_*,
unless calling pci_read_config_word() ;-)

Thanks,
H.Seto