ALPS psmouse_reset on reconnect confusing Tecra M2

ALPS psmouse_reset on reconnect confusing Tecra M2

[Mike Waychison]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I just upgrade my Tecra M2 this weekend to the latest GIT tree and
noticed that my mouse pointer/touchpad is now broken on resume.

Investigating, it appears that mouse device gets confused due to the
introduced psmouse_reset(psmouse) during reconnect:

http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f3a5c73d5ecb40909db662c4d2ace497b25c5940

Before resume, this is the output I get:

Jul  3 01:25:11 lapdance kernel: alps.c: E6 report: 00 00 64
Jul  3 01:25:11 lapdance kernel: alps.c: E7 report: 22 02 14
Jul  3 01:25:11 lapdance kernel: alps.c: E6 report: 00 00 64
Jul  3 01:25:11 lapdance kernel: alps.c: E7 report: 22 02 14
Jul  3 01:25:12 lapdance kernel: alps.c: Status: 05 01 0a
Jul  3 01:25:12 lapdance kernel: alps.c: Enabling hardware tapping
Jul  3 01:25:12 lapdance kernel: alps.c: Status: 05 01 0a
Jul  3 01:25:12 lapdance kernel: input: DualPoint Stick on isa0060/serio1
Jul  3 01:25:12 lapdance kernel: input: AlpsPS/2 ALPS DualPoint TouchPad
on isa0060/serio1

If I then suspend and resume:

Jul  3 01:26:13 lapdance kernel: alps.c: E6 report: 00 00 64
Jul  3 01:26:13 lapdance kernel: alps.c: E7 report: 73 02 0a
Jul  3 01:26:14 lapdance kernel: alps.c: E6 report: 00 00 64
Jul  3 01:26:14 lapdance kernel: alps.c: E7 report: 73 02 0a
Jul  3 01:26:14 lapdance kernel: alps.c: Status: 15 01 0a
Jul  3 01:26:14 lapdance kernel: alps.c: Enabling hardware tapping
Jul  3 01:26:14 lapdance kernel: alps.c: Status: 15 01 0a
Jul  3 01:26:14 lapdance kernel: input: PS/2 Mouse on isa0060/serio1
Jul  3 01:26:14 lapdance kernel: input: AlpsPS/2 ALPS GlidePoint on
isa0060/serio1

The pointer is confused, and a hard shutdown and boot is required to
restore it.  A reboot alone won't do the trick.

FWIW, I was using the regular IMPS/2 X mouse driver, though I later
tried using the synaptics X driver and that didn't work either.

Other things I've tried include trying psmouse_reset until it returns
successfully, though sometimes it did, and other times it didn't, even
after 100 retries.  In either case the pointer didn't come back.

Removing the psmouse_reset makes the pointer come back properly 100% of
the time.

Are you sure that the psmouse_reset is really the right thing to do?

(worked fine in 2.6.11-rc2).

Thanks,

Mike Waychison
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCyaaadQs4kOxk3/MRAqvBAKCeaYgsMFPrubb+7p8Se/Z6BwEmcwCfXPOB
yVQkUCORLUKyGGO5ttnfjIs=
=B1O/
-----END PGP SIGNATURE-----

Re: ALPS psmouse_reset on reconnect confusing Tecra M2

[Dmitry Torokhov]

On Monday 04 July 2005 16:14, Mike Waychison wrote:
> Hi,
> 
> I just upgrade my Tecra M2 this weekend to the latest GIT tree and
> noticed that my mouse pointer/touchpad is now broken on resume.
> 
> Investigating, it appears that mouse device gets confused due to the
> introduced psmouse_reset(psmouse) during reconnect:
>
> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f3a5c73d5ecb40909db662c4d2ace497b25c5940

Hi,

Please try the following patch:

	http://www.ucw.cz/~vojtech/input/alps-suspend-typo
 
> Are you sure that the psmouse_reset is really the right thing to do?

Yes, it helps on some other laptops.

-- 
Dmitry

Re: ALPS psmouse_reset on reconnect confusing Tecra M2

[Mark Lord]

Ahh.. that might explain some weirdness observed here, as well.

Thanks!

Dmitry Torokhov wrote:
>
> Please try the following patch:
> 
> 	http://www.ucw.cz/~vojtech/input/alps-suspend-typo

Re: ALPS psmouse_reset on reconnect confusing Tecra M2

[Mike Waychison]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dmitry Torokhov wrote:
> On Monday 04 July 2005 16:14, Mike Waychison wrote:
> 
>>Hi,
>>
>>I just upgrade my Tecra M2 this weekend to the latest GIT tree and
>>noticed that my mouse pointer/touchpad is now broken on resume.
>>
>>Investigating, it appears that mouse device gets confused due to the
>>introduced psmouse_reset(psmouse) during reconnect:
>>
>>http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f3a5c73d5ecb40909db662c4d2ace497b25c5940
> 
> 
> Hi,
> 
> Please try the following patch:
> 
> 	http://www.ucw.cz/~vojtech/input/alps-suspend-typo
>  
>

Yup.  This did the trick :D

Thanks,

Mike Waychison
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCyrfldQs4kOxk3/MRAs6CAJwMeMy8uZK3wVxwptihGtyRQUKVPQCaAnSO
XP1TQKemZRAbwiy/0UovARM=
=YVQS
-----END PGP SIGNATURE-----

Re: ALPS psmouse_reset on reconnect confusing Tecra M2

[Micheal Marineau]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

Dmitry Torokhov wrote:
> On Monday 04 July 2005 16:14, Mike Waychison wrote:
> 
>>Hi,
>>
>>I just upgrade my Tecra M2 this weekend to the latest GIT tree and
>>noticed that my mouse pointer/touchpad is now broken on resume.
>>
>>Investigating, it appears that mouse device gets confused due to the
>>introduced psmouse_reset(psmouse) during reconnect:
>>
>>http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f3a5c73d5ecb40909db662c4d2ace497b25c5940
> 
> 
> Hi,
> 
> Please try the following patch:
> 
> 	http://www.ucw.cz/~vojtech/input/alps-suspend-typo
>  

This fixed the problem for mylaptop, but ONLY if I had #define DEBUG in
alps.c, switch it back to the usual #undef and the exact same problem
happens.  I've got no idea what's going on, I'll poke at it more when
I'm awake....


-- 
Michael Marineau
marineam@engr.orst.edu
Oregon State University

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

Re: ALPS psmouse_reset on reconnect confusing Tecra M2

[Dmitry Torokhov]

On Tuesday 05 July 2005 23:53, Micheal Marineau wrote:
> Dmitry Torokhov wrote:
> > On Monday 04 July 2005 16:14, Mike Waychison wrote:
> > 
> >>Hi,
> >>
> >>I just upgrade my Tecra M2 this weekend to the latest GIT tree and
> >>noticed that my mouse pointer/touchpad is now broken on resume.
> >>
> >>Investigating, it appears that mouse device gets confused due to the
> >>introduced psmouse_reset(psmouse) during reconnect:
> >>
> >>http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f3a5c73d5ecb40909db662c4d2ace497b25c5940
> > 
> > 
> > Hi,
> > 
> > Please try the following patch:
> > 
> > 	http://www.ucw.cz/~vojtech/input/alps-suspend-typo
> >  
> 
> This fixed the problem for mylaptop, but ONLY if I had #define DEBUG in
> alps.c, switch it back to the usual #undef and the exact same problem
> happens.  I've got no idea what's going on, I'll poke at it more when
> I'm awake....
> 

Hi,

Sorry, any update on this topic? Does it still only work with DEBUG?

Thanks!

-- 
Dmitry

Re: ALPS psmouse_reset on reconnect confusing Tecra M2

[Micheal Marineau]

[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]

Dmitry Torokhov wrote:
> On Tuesday 05 July 2005 23:53, Micheal Marineau wrote:
> 
>>Dmitry Torokhov wrote:
>>
>>>On Monday 04 July 2005 16:14, Mike Waychison wrote:
>>>
>>>
>>>>Hi,
>>>>
>>>>I just upgrade my Tecra M2 this weekend to the latest GIT tree and
>>>>noticed that my mouse pointer/touchpad is now broken on resume.
>>>>
>>>>Investigating, it appears that mouse device gets confused due to the
>>>>introduced psmouse_reset(psmouse) during reconnect:
>>>>
>>>>http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f3a5c73d5ecb40909db662c4d2ace497b25c5940
>>>
>>>
>>>Hi,
>>>
>>>Please try the following patch:
>>>
>>>	http://www.ucw.cz/~vojtech/input/alps-suspend-typo
>>> 
>>
>>This fixed the problem for mylaptop, but ONLY if I had #define DEBUG in
>>alps.c, switch it back to the usual #undef and the exact same problem
>>happens.  I've got no idea what's going on, I'll poke at it more when
>>I'm awake....
>>
> 
> 
> Hi,
> 
> Sorry, any update on this topic? Does it still only work with DEBUG?
> 
> Thanks!

I have no clue why DEBUG helped, but it seems to have been simply dumb
luck as the issue came up again with DEBUG still on.  An easy workaround
was to compile psmouse as a module and unload/load it during the suspend
cycle (automatic with the hibernate script, it has psmouse in it's
blacklist).  I haven't dug into it to see what exactly doesn't get
initilized during resume that should.


-- 
Michael Marineau
marineam@engr.orst.edu
Oregon State University


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

Re: ALPS psmouse_reset on reconnect confusing Tecra M2

[Micheal Marineau]

[-- Attachment #1: Type: text/plain, Size: 1957 bytes --]

Micheal Marineau wrote:
> Dmitry Torokhov wrote:
> 
>>On Tuesday 05 July 2005 23:53, Micheal Marineau wrote:
>>
>>
>>>Dmitry Torokhov wrote:
>>>
>>>
>>>>On Monday 04 July 2005 16:14, Mike Waychison wrote:
>>>>
>>>>
>>>>
>>>>>Hi,
>>>>>
>>>>>I just upgrade my Tecra M2 this weekend to the latest GIT tree and
>>>>>noticed that my mouse pointer/touchpad is now broken on resume.
>>>>>
>>>>>Investigating, it appears that mouse device gets confused due to the
>>>>>introduced psmouse_reset(psmouse) during reconnect:
>>>>>
>>>>>http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f3a5c73d5ecb40909db662c4d2ace497b25c5940
>>>>
>>>>
>>>>Hi,
>>>>
>>>>Please try the following patch:
>>>>
>>>>	http://www.ucw.cz/~vojtech/input/alps-suspend-typo
>>>>
>>>
>>>This fixed the problem for mylaptop, but ONLY if I had #define DEBUG in
>>>alps.c, switch it back to the usual #undef and the exact same problem
>>>happens.  I've got no idea what's going on, I'll poke at it more when
>>>I'm awake....
>>>
>>
>>
>>Hi,
>>
>>Sorry, any update on this topic? Does it still only work with DEBUG?
>>
>>Thanks!
> 
> 
> I have no clue why DEBUG helped, but it seems to have been simply dumb
> luck as the issue came up again with DEBUG still on.  An easy workaround
> was to compile psmouse as a module and unload/load it during the suspend
> cycle (automatic with the hibernate script, it has psmouse in it's
> blacklist).  I haven't dug into it to see what exactly doesn't get
> initilized during resume that should.
> 
> 

Here's a little more info though:
dmesg on boot/re-load module
alps.c: E6 report: 00 00 64
alps.c: E7 report: 63 03 c8
alps.c: E6 report: 00 00 64
alps.c: E7 report: 63 03 c8
alps.c: Status: 10 00 64

dmesg after a resume (no reloading of the module)
alps.c: E6 report: 00 00 64
alps.c: E7 report: 63 03 c8
alps.c: Status: 10 00 64
alps.c: Status: 10 00 64


-- 
Michael Marineau
marineam@engr.orst.edu
Oregon State University


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

Re: ALPS psmouse_reset on reconnect confusing Tecra M2

[Micheal Marineau]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

Dmitry Torokhov wrote:
> On Tuesday 05 July 2005 23:53, Micheal Marineau wrote:
> 
>>Dmitry Torokhov wrote:
>>
>>>On Monday 04 July 2005 16:14, Mike Waychison wrote:
>>>
>>>
>>>>Hi,
>>>>
>>>>I just upgrade my Tecra M2 this weekend to the latest GIT tree and
>>>>noticed that my mouse pointer/touchpad is now broken on resume.
>>>>
>>>>Investigating, it appears that mouse device gets confused due to the
>>>>introduced psmouse_reset(psmouse) during reconnect:
>>>>
>>>>http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f3a5c73d5ecb40909db662c4d2ace497b25c5940
>>>
>>>
>>>Hi,
>>>
>>>Please try the following patch:
>>>
>>>	http://www.ucw.cz/~vojtech/input/alps-suspend-typo
>>> 
>>
>>This fixed the problem for mylaptop, but ONLY if I had #define DEBUG in
>>alps.c, switch it back to the usual #undef and the exact same problem
>>happens.  I've got no idea what's going on, I'll poke at it more when
>>I'm awake....
>>
> 
> 
> Hi,
> 
> Sorry, any update on this topic? Does it still only work with DEBUG?
> 
> Thanks!
> 

Yey! fixed it, simple little patch, just updates the alps_model_info
struct. Here's a link so my mail client won't mess up the white space:
http://dev.gentoo.org/~marineam/files/alps-dell8500-dualpoint.patch

(note, this sill requires the alps-suspend-typo fix)

-- 
Michael Marineau
marineam@engr.orst.edu
Oregon State University

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

Re: ALPS psmouse_reset on reconnect confusing Tecra M2

[Vojtech Pavlik]

On Sun, Jul 10, 2005 at 01:03:53AM -0700, Micheal Marineau wrote:

> Yey! fixed it, simple little patch, just updates the alps_model_info
> struct. Here's a link so my mail client won't mess up the white space:
> http://dev.gentoo.org/~marineam/files/alps-dell8500-dualpoint.patch
> 
> (note, this sill requires the alps-suspend-typo fix)

It's hard to believe your patch

--- linux-2.6.12-suspend2.orig/drivers/input/mouse/alps.c	2005-07-07 23:50:48.000000000 -0700
+++ linux-2.6.12-suspend2/drivers/input/mouse/alps.c	2005-07-10 00:51:36.000000000 -0700
@@ -48,1 +48,1 @@
-	{ { 0x63, 0x03, 0xc8 }, 0xf8, 0xf8, ALPS_PASS },		/* Dell Latitude D800 */
+	{ { 0x63, 0x03, 0xc8 }, 0xf8, 0xf8, ALPS_PASS | ALPS_DUALPOINT }, /* Dell Latitude D800, Inspiron 8500 */

can fix it, because the ALPS_DUALPOINT constant doesn't affect the
initalization behavior at all, only the way how TouchPoint data are
decoded. 

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR

Re: ALPS psmouse_reset on reconnect confusing Tecra M2

[Micheal Marineau]

[-- Attachment #1: Type: text/plain, Size: 1720 bytes --]

Vojtech Pavlik wrote:
> On Sun, Jul 10, 2005 at 01:03:53AM -0700, Micheal Marineau wrote:
> 
> 
>>Yey! fixed it, simple little patch, just updates the alps_model_info
>>struct. Here's a link so my mail client won't mess up the white space:
>>http://dev.gentoo.org/~marineam/files/alps-dell8500-dualpoint.patch
>>
>>(note, this sill requires the alps-suspend-typo fix)
> 
> 
> It's hard to believe your patch
> 
> --- linux-2.6.12-suspend2.orig/drivers/input/mouse/alps.c	2005-07-07 23:50:48.000000000 -0700
> +++ linux-2.6.12-suspend2/drivers/input/mouse/alps.c	2005-07-10 00:51:36.000000000 -0700
> @@ -48,1 +48,1 @@
> -	{ { 0x63, 0x03, 0xc8 }, 0xf8, 0xf8, ALPS_PASS },		/* Dell Latitude D800 */
> +	{ { 0x63, 0x03, 0xc8 }, 0xf8, 0xf8, ALPS_PASS | ALPS_DUALPOINT }, /* Dell Latitude D800, Inspiron 8500 */
> 
> can fix it, because the ALPS_DUALPOINT constant doesn't affect the
> initalization behavior at all, only the way how TouchPoint data are
> decoded. 
> 

I don't really understand what's going on with that.  It's not the root
issue for sure, just now after a run of about 15 suspends the mouse
finally capped out. Somehow that made it slightly more reliable? Or it
was just dumb luck that I couldn't reproduce it yesterday, but I managed
to do it once today.

My best guess is that something more needs to be done to priv->dev2 to
make sure it initilizes properly but I don't know what, I'm having some
difficulty understanding the alps driver.

But it could be something independent of resume, I have a gentoo user
with another inspiron 8500 who says even with 2.6.12, the dualpoint
stick doesn't initilize a lot of the time even on boot.

-- 
Michael Marineau
marineam@engr.orst.edu
Oregon State University

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]