From: Micheal Marineau <marineam@engr.orst.edu>
To: Matthew Garrett <mgarrett@chiark.greenend.org.uk>
Cc: linux-kernel@linux.kernel.org
Subject: Re: [PATCH][help?] Radeonfb acpi resume
Date: Tue, 12 Jul 2005 06:39:54 -0700 [thread overview]
Message-ID: <42D3C82A.3010407@engr.orst.edu> (raw)
In-Reply-To: <E1DsHSJ-0006kr-00@chiark.greenend.org.uk>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
Matthew Garrett wrote:
> Micheal Marineau <marineam@engr.orst.edu> wrote:
>
>
>>+ if (pdev->dev.power.power_state != 4)
>>+ {
>>+ pci_restore_state (pdev);
>>+ acpi_vgapost (pdev->devfn);
>>+ }
>
>
> Please *don't* make this unconditional. There's no guarantee that the
> video BIOS is postable after initial system boot. A boot-time parameter
> to enable it seems reasonable, but in general we're likely to stand a
> much better chance getting it working in userspace.
A kernel parameter seems reasonable, I assume that pci_restore_state
shoule remain unconditional right? Userspace works just fine if
the frame buffer is not used, but it has to be done in kernel when
using a frame buffer.
--
Michael Marineau
marineam@engr.orst.edu
Oregon State University
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
next prev parent reply other threads:[~2005-07-12 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-10 22:19 [PATCH][help?] Radeonfb acpi resume Micheal Marineau
2005-07-10 22:23 ` Micheal Marineau
2005-07-11 15:11 ` Pavel Machek
2005-07-11 18:50 ` Micheal Marineau
2005-07-11 18:56 ` Pavel Machek
2005-07-12 4:32 ` Micheal Marineau
[not found] ` <E1DsHSJ-0006kr-00@chiark.greenend.org.uk>
2005-07-12 13:39 ` Micheal Marineau [this message]
2005-07-13 0:32 ` Benjamin Herrenschmidt
2005-07-13 5:31 ` Micheal Marineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42D3C82A.3010407@engr.orst.edu \
--to=marineam@engr.orst.edu \
--cc=linux-kernel@linux.kernel.org \
--cc=mgarrett@chiark.greenend.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox