From: Jan Blunck <j.blunck@tu-harburg.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, joern@wohnheim.fh-wedel.de
Subject: Re: [PATCH] generic_file_sendpage
Date: Wed, 20 Jul 2005 21:03:40 +0200 [thread overview]
Message-ID: <42DEA00C.7010407@tu-harburg.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0507150848500.19183@g5.osdl.org>
Linus Torvalds wrote:
>
> "sendfile()" in general I think has been a mistake. It's too specialized,
> and the interface has always sucked.
Ok, you're right. I will have a look at the pipe buffer stuff.
> As Andrew pointed out, it actually
> needs to limit the number of buffers in flight partly because otherwise
> you have uninterruptible kernel work etc etc.
Hmm, sendfile() uses do_generic_mapping_read() which is calling the
file_send_actor() per page. The actor calls ->sendpage(). I don't see
any situation how this could lead to uninterruptible kernel work when
the sendpage() itself is checking for signals. There are only 2 pages in
flight in this case.
Jan
prev parent reply other threads:[~2005-07-20 19:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-15 10:48 [PATCH] generic_file_sendpage Jan Blunck
2005-07-15 11:06 ` Andrew Morton
2005-07-15 11:22 ` Jörn Engel
2005-07-15 13:13 ` Jan Engelhardt
2005-07-15 16:08 ` Linus Torvalds
2005-07-15 19:02 ` Jan Engelhardt
2005-07-15 19:16 ` Linus Torvalds
2005-07-21 5:34 ` Herbert Poetzl
2005-07-15 12:34 ` [PATCH] generic_file_sendpage (updated patch) Jan Blunck
2005-07-15 16:01 ` [PATCH] generic_file_sendpage Linus Torvalds
2005-07-20 19:03 ` Jan Blunck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42DEA00C.7010407@tu-harburg.de \
--to=j.blunck@tu-harburg.de \
--cc=akpm@osdl.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox