public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Hugh Dickins <hugh@veritas.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [patch 1/6] mm: comment rmap
Date: Tue, 26 Jul 2005 18:16:51 +1000	[thread overview]
Message-ID: <42E5F173.3010409@yahoo.com.au> (raw)
In-Reply-To: <42E5F139.70002@yahoo.com.au>

[-- Attachment #1: Type: text/plain, Size: 5 bytes --]

1/6


[-- Attachment #2: mm-comment-rmap.patch --]
[-- Type: text/plain, Size: 709 bytes --]

Just be clear that VM_RESERVED pages here are a bug, and the test
is not there because they are expected.

Signed-off-by: Nick Piggin <npiggin@suse.de>

Index: linux-2.6/mm/rmap.c
===================================================================
--- linux-2.6.orig/mm/rmap.c
+++ linux-2.6/mm/rmap.c
@@ -532,6 +532,8 @@ static int try_to_unmap_one(struct page 
 	 * If the page is mlock()d, we cannot swap it out.
 	 * If it's recently referenced (perhaps page_referenced
 	 * skipped over this mm) then we should reactivate it.
+	 *
+	 * Pages belonging to VM_RESERVED regions should not happen here.
 	 */
 	if ((vma->vm_flags & (VM_LOCKED|VM_RESERVED)) ||
 			ptep_clear_flush_young(vma, address, pte)) {

  reply	other threads:[~2005-07-26  8:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-26  8:15 [patch 0/6] remove PageReserved Nick Piggin
2005-07-26  8:16 ` Nick Piggin [this message]
2005-07-26  8:17   ` [patch 2/6] mm: micro-optimise rmap Nick Piggin
2005-07-26  8:18     ` [patch 3/6] mm: cleanup rmap Nick Piggin
2005-07-26  8:19       ` [patch 4/6] mm: remove atomic Nick Piggin
2005-07-26  8:20         ` [patch 5/6] mm: remap ZERO_PAGE mappings Nick Piggin
2005-07-26  8:20           ` [patch 6/6] mm: core remove PageReserved Nick Piggin
2005-07-26  8:56             ` [patch 6/6] mm: core remove PageReserved (take 2) Nick Piggin
2005-07-27 11:30     ` [patch 2/6] mm: micro-optimise rmap Alexander Nyberg
2005-07-28  0:53       ` Nick Piggin
2005-07-26  8:21 ` [patch 0/6] remove PageReserved Nick Piggin
2005-07-26 13:09 ` Kumar Gala
2005-07-27  0:22   ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42E5F173.3010409@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox