public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>, "Brown, Len" <len.brown@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: VIA PCI routing problem
Date: Thu, 28 Jul 2005 22:10:15 +1000	[thread overview]
Message-ID: <42E8CB27.4010100@yahoo.com.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi,

Sorry in taking so long to track this down. I just got motivated
today.

I have a VIA SMP system and somewhere between 2.6.12-rc3 and 2.6.12
the USB mouse started moving around really slowly. Anyway, it turns
out that the attached patch (against 2.6.13-rc3-git8) fixes the problem.

Let me know if any info is needed or if you would like me to test a
patch.

This is a regression versus 2.6.11 so it would be good to have a fix in
2.6.13.

Thanks,
Nick

-- 
SUSE Labs, Novell Inc.


[-- Attachment #2: via-irq-revert.patch --]
[-- Type: text/plain, Size: 1710 bytes --]

Index: linux-2.6/arch/i386/pci/irq.c
===================================================================
--- linux-2.6.orig/arch/i386/pci/irq.c	2005-07-28 19:03:48.000000000 +1000
+++ linux-2.6/arch/i386/pci/irq.c	2005-07-28 21:58:52.000000000 +1000
@@ -1132,6 +1132,7 @@ static int pirq_enable_irq(struct pci_de
 		printk(KERN_WARNING "PCI: No IRQ known for interrupt pin %c of device %s.%s\n",
 		       'A' + pin, pci_name(dev), msg);
 	}
+	pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq & 15);
 	return 0;
 }
 
Index: linux-2.6/drivers/pci/quirks.c
===================================================================
--- linux-2.6.orig/drivers/pci/quirks.c	2005-07-28 21:41:56.000000000 +1000
+++ linux-2.6/drivers/pci/quirks.c	2005-07-28 21:59:35.000000000 +1000
@@ -499,6 +499,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_V
  */
 static void quirk_via_irq(struct pci_dev *dev)
 {
+#if 0
 	u8 irq, new_irq;
 
 	new_irq = dev->irq & 0xf;
@@ -509,6 +510,7 @@ static void quirk_via_irq(struct pci_dev
 		udelay(15);	/* unknown if delay really needed */
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
+#endif
 }
 DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
 
Index: linux-2.6/drivers/acpi/pci_irq.c
===================================================================
--- linux-2.6.orig/drivers/acpi/pci_irq.c	2005-07-28 19:04:00.000000000 +1000
+++ linux-2.6/drivers/acpi/pci_irq.c	2005-07-28 21:58:14.000000000 +1000
@@ -444,6 +444,8 @@ acpi_pci_irq_enable (
 		}
  	}
 
+	pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq & 15);
+
 	dev->irq = acpi_register_gsi(irq, edge_level, active_high_low);
 
 	printk(KERN_INFO PREFIX "PCI Interrupt %s[%c] -> ",

             reply	other threads:[~2005-07-28 12:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-28 12:10 Nick Piggin [this message]
2005-07-28 15:37 ` VIA PCI routing problem Bjorn Helgaas
2005-07-28 22:28   ` Nick Piggin
  -- strict thread matches above, loose matches on Subject: below --
2005-07-28 18:36 Brown, Len
2005-07-28 22:43 ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42E8CB27.4010100@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@osdl.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox