VIA PCI routing problem

VIA PCI routing problem

[Nick Piggin]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi,

Sorry in taking so long to track this down. I just got motivated
today.

I have a VIA SMP system and somewhere between 2.6.12-rc3 and 2.6.12
the USB mouse started moving around really slowly. Anyway, it turns
out that the attached patch (against 2.6.13-rc3-git8) fixes the problem.

Let me know if any info is needed or if you would like me to test a
patch.

This is a regression versus 2.6.11 so it would be good to have a fix in
2.6.13.

Thanks,
Nick

-- 
SUSE Labs, Novell Inc.


[-- Attachment #2: via-irq-revert.patch --]
[-- Type: text/plain, Size: 1710 bytes --]

Index: linux-2.6/arch/i386/pci/irq.c
===================================================================
--- linux-2.6.orig/arch/i386/pci/irq.c	2005-07-28 19:03:48.000000000 +1000
+++ linux-2.6/arch/i386/pci/irq.c	2005-07-28 21:58:52.000000000 +1000
@@ -1132,6 +1132,7 @@ static int pirq_enable_irq(struct pci_de
 		printk(KERN_WARNING "PCI: No IRQ known for interrupt pin %c of device %s.%s\n",
 		       'A' + pin, pci_name(dev), msg);
 	}
+	pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq & 15);
 	return 0;
 }
 
Index: linux-2.6/drivers/pci/quirks.c
===================================================================
--- linux-2.6.orig/drivers/pci/quirks.c	2005-07-28 21:41:56.000000000 +1000
+++ linux-2.6/drivers/pci/quirks.c	2005-07-28 21:59:35.000000000 +1000
@@ -499,6 +499,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_V
  */
 static void quirk_via_irq(struct pci_dev *dev)
 {
+#if 0
 	u8 irq, new_irq;
 
 	new_irq = dev->irq & 0xf;
@@ -509,6 +510,7 @@ static void quirk_via_irq(struct pci_dev
 		udelay(15);	/* unknown if delay really needed */
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
+#endif
 }
 DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
 
Index: linux-2.6/drivers/acpi/pci_irq.c
===================================================================
--- linux-2.6.orig/drivers/acpi/pci_irq.c	2005-07-28 19:04:00.000000000 +1000
+++ linux-2.6/drivers/acpi/pci_irq.c	2005-07-28 21:58:14.000000000 +1000
@@ -444,6 +444,8 @@ acpi_pci_irq_enable (
 		}
  	}
 
+	pci_write_config_byte(dev, PCI_INTERRUPT_LINE, irq & 15);
+
 	dev->irq = acpi_register_gsi(irq, edge_level, active_high_low);
 
 	printk(KERN_INFO PREFIX "PCI Interrupt %s[%c] -> ",

Re: VIA PCI routing problem

[Bjorn Helgaas]

On Thursday 28 July 2005 6:10 am, Nick Piggin wrote:
> I have a VIA SMP system and somewhere between 2.6.12-rc3 and 2.6.12
> the USB mouse started moving around really slowly. Anyway, it turns
> out that the attached patch (against 2.6.13-rc3-git8) fixes the problem.

Can you try this:

Index: work/drivers/pci/quirks.c
===================================================================
--- work.orig/drivers/pci/quirks.c	2005-07-25 15:04:26.000000000 -0600
+++ work/drivers/pci/quirks.c	2005-07-28 09:26:09.000000000 -0600
@@ -503,7 +503,7 @@
 
 	new_irq = dev->irq & 0xf;
 	pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
-	if (new_irq != irq) {
+	if (1 || new_irq != irq) {
 		printk(KERN_INFO "PCI: Via IRQ fixup for %s, from %d to %d\n",
 			pci_name(dev), irq, new_irq);
 		udelay(15);	/* unknown if delay really needed */


If that doesn't help, remove it and see if this does:

Index: work/drivers/pci/quirks.c
===================================================================
--- work.orig/drivers/pci/quirks.c	2005-07-25 15:04:26.000000000 -0600
+++ work/drivers/pci/quirks.c	2005-07-28 09:27:23.000000000 -0600
@@ -510,7 +510,7 @@
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * PIIX3 USB: We have to disable USB interrupts that are


Can you also include "lspci" output?

Re: VIA PCI routing problem

[Nick Piggin]

Bjorn Helgaas wrote:

> 
> Can you try this:
> 
[...]
> 
> 
> If that doesn't help, remove it and see if this does:
> 
[...]
> 
> Can you also include "lspci" output?
> 

Neither worked. I'll open a bugzilla and include lspci and dmesg there.

-- 
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com 

RE: VIA PCI routing problem

[Brown, Len]

>Sorry in taking so long to track this down. I just got motivated
>today.
>
>I have a VIA SMP system and somewhere between 2.6.12-rc3 and 2.6.12
>the USB mouse started moving around really slowly. Anyway, it turns
>out that the attached patch (against 2.6.13-rc3-git8) fixes 
>the problem.
>
>Let me know if any info is needed or if you would like me to test a
>patch.
>
>This is a regression versus 2.6.11 so it would be good to have a fix in
>2.6.13.

Fix two systems, break another...

Nick, can you open a bugzilla on this and put your lspci -vv
and dmesg into it.  Apparently the quirk is good for some
machines and not as good for others and we need to get smarter
about when to apply it.

thanks,
-Len

Re: VIA PCI routing problem

[Nick Piggin]

Brown, Len wrote:

> 
> Fix two systems, break another...
> 
> Nick, can you open a bugzilla on this and put your lspci -vv
> and dmesg into it.  Apparently the quirk is good for some
> machines and not as good for others and we need to get smarter
> about when to apply it.
> 

OK, done. I put it under ACPI though I'm not sure whether that's
the right place for it.

-- 
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com