From: "Antonino A. Daplas" <adaplas@gmail.com>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: colormap fixes
Date: Fri, 29 Jul 2005 06:16:48 +0800 [thread overview]
Message-ID: <42E95950.2080101@gmail.com> (raw)
In-Reply-To: <9e473391050728074573e40038@mail.gmail.com>
Jon Smirl wrote:
> Can you review this fix for the issues below? I fixed things to
> automatically adjust the number of entries to whatever fits in
> PAGE_SIZE.
>
> diff --git a/drivers/video/fbsysfs.c b/drivers/video/fbsysfs.c
> --- a/drivers/video/fbsysfs.c
> +++ b/drivers/video/fbsysfs.c
> @@ -244,15 +244,15 @@ static ssize_t show_virtual(struct class
>
> /* Format for cmap is "%02x%c%4x%4x%4x\n" */
>
Why is the alpha channel not given the same weight as the RGB? Wouldn't
it be correct to also give it 4 bytes (16 bits) Also, what would happen if
you exceed 256 entries, you've only alloted a maximum of 256 for the
index? This will also be a problem because you cannot access cmap entries
past 255.
So, 4 bytes per channel + 4 bytes for the index will be needed per entry,
Tony
prev parent reply other threads:[~2005-07-28 22:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200507280031.j6S0V3L3016861@hera.kernel.org>
2005-07-28 7:54 ` [PATCH] fbdev: colormap fixes Geert Uytterhoeven
2005-07-28 13:07 ` Jon Smirl
2005-07-28 13:40 ` Geert Uytterhoeven
2005-07-28 14:50 ` [Linux-fbdev-devel] " Antonino A. Daplas
2005-07-28 15:59 ` Geert Uytterhoeven
2005-07-28 16:29 ` Jon Smirl
2005-07-28 18:18 ` Jon Smirl
2005-07-28 20:03 ` Geert Uytterhoeven
2005-07-28 20:15 ` Jon Smirl
2005-07-28 20:21 ` Jon Smirl
2005-07-28 20:50 ` Jon Smirl
2005-07-28 21:39 ` Geert Uytterhoeven
2005-07-28 21:50 ` Jon Smirl
2005-07-28 22:28 ` Antonino A. Daplas
2005-07-29 7:43 ` Geert Uytterhoeven
2005-07-29 10:34 ` Jon Smirl
2005-07-29 20:20 ` James Simmons
2005-07-28 23:19 ` Antonino A. Daplas
2005-07-29 20:13 ` James Simmons
2005-07-28 14:45 ` Jon Smirl
2005-07-28 15:56 ` Geert Uytterhoeven
2005-07-28 19:31 ` Jon Smirl
2005-07-28 20:04 ` Geert Uytterhoeven
2005-07-28 22:16 ` Antonino A. Daplas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42E95950.2080101@gmail.com \
--to=adaplas@gmail.com \
--cc=akpm@osdl.org \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox