Re: Linux 2.6.13-rc4

Cal Peake
2005-07-29T19:03:47Z

On Fri, 29 Jul 2005, Mickey Stein wrote:

> This is regarding *-rc4 and *-rc4-git1: I slapped together my favorite config
> and gave it a test run. It had a bit of a problem and ground to a halt after
> spewing these into the log.
>
> If I can find the time tomorrow morning, I'll leave parport_pc commented out
> of modprobe.conf and see if something else pops loose. I don't use the
> parallel port, but I try to keep a fairly robust config for noticing bugs.

Hi Mick,

Can you please try the patch below from Linus (or -git2 tomorrow) and
confirm that it fixes it for you?

thx,
-cp

--- a/include/asm-i386/bitops.h
+++ b/include/asm-i386/bitops.h
@@ -335,14 +335,13 @@ static inline unsigned long __ffs(unsign
static inline int find_first_bit(const unsigned long *addr, unsigned size)
{
int x = 0;
- do {
- if (*addr)
- return __ffs(*addr) + x;
- addr++;
- if (x >= size)
- break;
+
+ while (x < size) {
+ unsigned long val = *addr++;
+ if (val)
+ return __ffs(val) + x;
x += (sizeof(*addr)<<3);
- } while (1);
+ }
return x;
}

--
"Democracy can learn some things from Communism; for example,
when a Communist politician is through, he is through."
-- Unknown