From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: jason.d.gaston@intel.com, mj@ucw.cz,
linux-kernel@vger.kernel.org, gregkh@suse.de
Subject: Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R
Date: Fri, 29 Jul 2005 18:29:48 -0400 [thread overview]
Message-ID: <42EAADDC.1010505@pobox.com> (raw)
In-Reply-To: <20050729152648.2c2fe390.akpm@osdl.org>
Andrew Morton wrote:
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>>[speaking to the audience] I wouldn't mind if someone did a pass
>>through pci_ids.h and removed all the constants that are not being used.
>> If constants are not being used, it's IMHO more appropriate to store
>>that info in pci.ids.
>
>
> It looks like Greg is planning on nuking pci.ids.
From the kernel, yes, that's been long planned. But not from existence.
The kernel source code is an inappropriate place to store random hex
numbers that the kernel itself does not use.
Or IOW, we shouldn't be knowingly storing dead code in linux/pci_ids.h :)
Jeff
next prev parent reply other threads:[~2005-07-29 22:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-29 21:55 [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R Gaston, Jason D
2005-07-29 22:21 ` Jeff Garzik
2005-07-29 22:26 ` Andrew Morton
2005-07-29 22:29 ` Jeff Garzik [this message]
2005-07-30 2:28 ` Grant Coady
2005-07-30 3:52 ` Jeff Garzik
2005-07-30 4:54 ` Grant Coady
2005-08-11 19:22 ` Jeff Garzik
2005-09-11 3:11 ` Greg KH
2005-09-11 8:00 ` Grant Coady
2005-09-11 8:51 ` Jeff Garzik
2005-09-11 20:40 ` Grant Coady
2005-09-13 6:46 ` Grant
2005-09-13 7:03 ` Greg KH
2005-09-13 8:14 ` Grant Coady
2005-11-02 5:38 ` Grant Coady
2005-07-30 9:42 ` Grant Coady
2005-08-11 19:23 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2005-07-29 16:24 Jason Gaston
2005-07-29 21:49 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42EAADDC.1010505@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=jason.d.gaston@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox