From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262869AbVG3Btx (ORCPT ); Fri, 29 Jul 2005 21:49:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262745AbVG3Bsa (ORCPT ); Fri, 29 Jul 2005 21:48:30 -0400 Received: from ylpvm12-ext.prodigy.net ([207.115.57.43]:50835 "EHLO ylpvm12.prodigy.net") by vger.kernel.org with ESMTP id S262866AbVG3BdB (ORCPT ); Fri, 29 Jul 2005 21:33:01 -0400 X-ORBL: [67.125.168.38] Message-ID: <42EAD8C8.7030701@pacbell.net> Date: Fri, 29 Jul 2005 18:32:56 -0700 From: Mickey Stein User-Agent: Mozilla Thunderbird 1.0.6-1.1.fc4 (X11/20050720) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Cal Peake CC: Kernel Mailing List , Linus Torvalds Subject: Re: Linux 2.6.13-rc4 References: <42EA1C8D.8080708@pacbell.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Cal Peake wrote: >On Fri, 29 Jul 2005, Mickey Stein wrote: > > > >>This is regarding *-rc4 and *-rc4-git1: I slapped together my favorite config >>and gave it a test run. It had a bit of a problem and ground to a halt after >>spewing these into the log. >> >>If I can find the time tomorrow morning, I'll leave parport_pc commented out >>of modprobe.conf and see if something else pops loose. I don't use the >>parallel port, but I try to keep a fairly robust config for noticing bugs. >> >> > >Hi Mick, > >Can you please try the patch below from Linus (or -git2 tomorrow) and >confirm that it fixes it for you? > >thx, >-cp > >--- a/include/asm-i386/bitops.h >+++ b/include/asm-i386/bitops.h >@@ -335,14 +335,13 @@ static inline unsigned long __ffs(unsign > static inline int find_first_bit(const unsigned long *addr, unsigned size) > { > int x = 0; >- do { >- if (*addr) >- return __ffs(*addr) + x; >- addr++; >- if (x >= size) >- break; >+ >+ while (x < size) { >+ unsigned long val = *addr++; >+ if (val) >+ return __ffs(val) + x; > x += (sizeof(*addr)<<3); >- } while (1); >+ } > return x; > } > > > Hi Cal, I'll give that a go in about 30 minutes and report back, hopefully on *rc4-* ;) . I'm not sure I'll be around in the morning so will apply this to today's and see. Thanks, Mickey