public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: zaitcev@redhat.com, greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: 2.6.13 ub 2/3: Fold one line
Date: Sun, 31 Jul 2005 02:38:07 -0400	[thread overview]
Message-ID: <42EC71CF.3080908@pobox.com> (raw)
In-Reply-To: <20050730.231829.59467939.davem@davemloft.net>

David S. Miller wrote:
> From: Pete Zaitcev <zaitcev@redhat.com>
> Date: Sat, 30 Jul 2005 22:51:45 -0700
> 
> 
>>-static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr, char *page)
>>+static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr,
>>+    char *page)
> 
> 
> FWIW, I am generally against this kind of thing at least
> for non-static functions.
> 
> I used to love this kind of code styling, until I started trying to
> often grep a tree to verify the types of arguments to some function.
> 
> With the above kind of construct, you get the first few types, but not
> all of them, in your grep output.

A better solution would be to stop naming_structures_as_complete_sentences.

IMO there's a happy balance between BSD's squash-everything-into-6-chars 
style and recent kernel code's tendency to bypass the ancient C 32-char 
limit.

But ah well ;-)

	Jeff




  reply	other threads:[~2005-07-31  6:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-31  5:51 2.6.13 ub 2/3: Fold one line Pete Zaitcev
2005-07-31  6:18 ` David S. Miller
2005-07-31  6:38   ` Jeff Garzik [this message]
2005-07-31 13:37 ` Yani Ioannou
2005-07-31 16:54   ` Grant Coady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42EC71CF.3080908@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=davem@davemloft.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox