Re: Driver for sata adapter promise sata300 tx4

Daniel Drake
2005-08-01T16:19:20Z

Otto Meier wrote:
> My question is also are these features (NCQ/TCQ) and the heigher
> datarate be supported by this
> modification? or is only the basic feature set of sata 150 TX4 supported?

NCQ support is under development. Search the archives for Jens Axboe's recent
patches to support this. I don't know about TCQ.

> Here is the patch:
>
> --- linux/drivers/scsi/sata_promise.c.orig 2005-08-01 17:09:48.474824778
> +0200
> +++ linux/drivers/scsi/sata_promise.c 2005-07-31 12:57:06.415979512 +0200

Your patch will not apply because it is linewrapped. You also need to submit
it in a mail of its own to the relevent lists and maintainer, with your
sign-off (see Documentation/SubmittingPatches)

> I just saw the patches of Luke Kosewski regarding the SATA150 TX4
> antipating
> them it might be right to modify the patch to
>
> + { PCI_VENDOR_ID_PROMISE, 0x3d17, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> + board_40518 },

It won't compile like this because board_40518 is not a valid identifier. I
also think it doesn't really matter as it looks like these identifier codes
have lost their numerical meanings, and now just signify:

board_2037x - 2 port SATA, maybe with an extra PATA port
board_20319 - 4 port SATA
board_20619 - 4 port PATA

Daniel