public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Simon Sudler <Simon.Sudler@gmx.net>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: reed-solomon lib
Date: Mon, 01 Aug 2005 17:48:50 +0200	[thread overview]
Message-ID: <42EE4462.9030101@gmx.net> (raw)

Hi folks,

I'm working with the reed-solomon lib. Since i use a
RS(255,191,64) code, i found a strange limitation in
the reed_solomon.c:

194:	/* Sanity checks */
         if (symsize < 1)
                 return NULL;
         if (fcr < 0 || fcr >= (1<<symsize))
                 return NULL;
         if (prim <= 0 || prim >= (1<<symsize))
                 return NULL;
         if (nroots < 0 || nroots >= (1<<symsize) || nroots > 8)
                 return NULL;

in line 201 the nroot are limited to max 8. I checkt the
original code from Phil Karn (http://cache.qualcomm.com/code/fec/)
in witch is no limitation. After a closer look a the original
code, i couldn't find any relevant difference exept for
the line above.
After removing of the "nroots > 8" my code was working fine...
perhaps someone was to carful to avoid a errors with the kmalloc
function in rs_init.

Cheers,
Simon


             reply	other threads:[~2005-08-01 15:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-01 15:48 Simon Sudler [this message]
2005-08-01 16:22 ` reed-solomon lib Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42EE4462.9030101@gmx.net \
    --to=simon.sudler@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox