public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josip Loncaric <josip@lanl.gov>
To: linux-kernel@vger.kernel.org
Subject: Time conversion error in linux-2.6.11.10/net/sunrpoc/svcsock.c
Date: Mon, 01 Aug 2005 15:11:48 -0600	[thread overview]
Message-ID: <42EE9014.7080205@lanl.gov> (raw)

Line 589 of linux-2.6.11.10/net/sunrpc/svcsock.c is obviously wrong:

                 skb->stamp.tv_usec = xtime.tv_nsec * 1000;

To convert nsec to usec, one should divide instead of multiplying:

                 skb->stamp.tv_usec = xtime.tv_nsec / 1000;

The same bug could be present in the latest kernels, although I haven't 
checked.  This bug makes svc_udp_recvfrom() timestamps incorrect.

Sincerely,
Josip



             reply	other threads:[~2005-08-01 21:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-01 21:11 Josip Loncaric [this message]
2005-08-01 22:56 ` [PATCH] net/sunrpc: fix time conversion error Nishanth Aravamudan
2005-08-02  0:03   ` Patrick McHardy
2005-08-02  0:11     ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42EE9014.7080205@lanl.gov \
    --to=josip@lanl.gov \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox