From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org, steiner@sgi.com
Subject: Re: [Patch] don't kick ALB in the presence of pinned task
Date: Tue, 02 Aug 2005 20:06:15 +1000 [thread overview]
Message-ID: <42EF4597.1080208@yahoo.com.au> (raw)
In-Reply-To: <20050802094318.GC20978@elte.hu>
Ingo Molnar wrote:
> * Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>>
>>Hmm, I would have hoped the new "all_pinned" logic should have handled
>>this case properly. [...]
>
>
> no, active_balance is a different case, not covered by the all_pinned
> logic. This is a HT-special scenario, where busiest->nr_running == 1,
> and we have to do active load-balancing. This does not go through
> move_tasks() and does not set all_pinned. (If nr_running werent 1 we'd
> not have to kick active load-balancing.)
>
Yeah I see. It looks like Suresh's patch should do a reasonable
job at doing "all pinned backoff" too, using the existing logic.
So I agree - great catch.
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2005-08-02 10:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-02 0:42 [Patch] don't kick ALB in the presence of pinned task Siddha, Suresh B
2005-08-02 6:09 ` Nick Piggin
2005-08-02 9:43 ` Ingo Molnar
2005-08-02 10:06 ` Nick Piggin [this message]
2005-08-02 21:12 ` Siddha, Suresh B
2005-08-02 9:27 ` Ingo Molnar
2005-08-09 23:08 ` allow the load to grow upto its cpu_power (was Re: [Patch] don't kick ALB in the presence of pinned task) Siddha, Suresh B
2005-08-10 0:27 ` Nick Piggin
2005-08-10 2:03 ` Siddha, Suresh B
2005-08-11 3:09 ` Nick Piggin
2005-08-11 18:14 ` Siddha, Suresh B
2005-08-11 23:49 ` Nick Piggin
2005-08-12 0:39 ` Siddha, Suresh B
2005-08-12 1:24 ` Nick Piggin
2005-08-12 1:44 ` Siddha, Suresh B
2005-08-10 7:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42EF4597.1080208@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox