Re: [patch 2.6.13-rc4] fix get_user_pages bug

Nick Piggin
2005-08-03T23:08:53Z

Linus Torvalds wrote:
>
> On Wed, 3 Aug 2005, Nick Piggin wrote:
>
>>Oh, it gets rid of the -1 for VM_FAULT_OOM. Doesn't seem like there
>>is a good reason for it, but might that break out of tree drivers?
>
>
> Ok, I applied this because it was reasonably pretty and I liked the
> approach. It seems buggy, though, since it was using "switch ()" to test
> the bits (wrongly, afaik),

Oops, thanks.

> and I'm going to apply the appended on top of
> it. Holler quickly if you disagreee..
>

No that looks fine. Should really be credited to Hugh... well
I guess everyone had some input into it though (Andrew, Hugh,
you, me). It probably doesn't matter too much.

Thanks everyone.

--
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com