Re: [patch 2.6.13-rc4] fix get_user_pages bug

Linus Torvalds
2005-08-04T15:40:45Z

On Thu, 4 Aug 2005, Alexander Nyberg wrote:
>
> Hardcoding is evil so it's good it gets cleaned up anyway.

Yes.

> > parisc, cris, m68k, frv, sh64, arm26 are also broken. Would you mind
> > resending a patch that fixes them all?
>
> Remove the hardcoding in return value checking of handle_mm_fault()

I only saw this one when I had already done it myself.

Your arm26 conversion was only partial, btw. Notice how it returns the
fault number (with a few extensions of its own) and processes it further?
I think I got that right.

Linus