Re: [patch 2.6.13-rc4] fix get_user_pages bug

Russell King
2005-08-04T16:29:35Z

On Fri, Aug 05, 2005 at 12:30:07AM +1000, Nick Piggin wrote:
> Alexander Nyberg wrote:
> > On Wed, Aug 03, 2005 at 09:12:37AM -0700 Linus Torvalds wrote:
> >
> >
> >>
> >>Ok, I applied this because it was reasonably pretty and I liked the
> >>approach. It seems buggy, though, since it was using "switch ()" to test
> >>the bits (wrongly, afaik), and I'm going to apply the appended on top of
> >>it. Holler quickly if you disagreee..
> >>
> >
> >
> > x86_64 had hardcoded the VM_ numbers so it broke down when the numbers
> > were changed.
> >
>
> Ugh, sorry I should have audited this but I really wasn't expecting
> it (famous last words). Hasn't been a good week for me.
>
> parisc, cris, m68k, frv, sh64, arm26 are also broken.
> Would you mind resending a patch that fixes them all?

ARM as well - fix is pending Linus pulling my tree...

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core