Re: [patch 2.6.13-rc4] fix get_user_pages bug

Robin Holt
2005-08-03T08:24:50Z

On Mon, Aug 01, 2005 at 11:18:42AM -0700, Linus Torvalds wrote:
> On Mon, 1 Aug 2005, Linus Torvalds wrote:
> >
> > Ie something like the below (which is totally untested, obviously, but I
> > think conceptually is a lot more correct, and obviously a lot simpler).
>
> I've tested it, and thought more about it, and I can't see any fault with
> the approach. In fact, I like it more. So it's checked in now (in a
> further simplified way, since the thing made "lookup_write" always be the
> same as just "write").
>
> Can somebody who saw the problem in the first place please verify?

Unfortunately, I can not get the user test to run against anything but the
SLES9 SP2 kernel. I took the commit 4ceb5db9757aaeadcf8fbbf97d76bd42aa4df0d6
and applied that diff to the SUSE kernel. It does fix the problem the
customer reported.

Thanks,
Robin Holt