Re: [patch 2.6.13-rc4] fix get_user_pages bug

Nick Piggin
2005-08-01T09:28:23Z

Ingo Molnar wrote:
> * Nick Piggin <nickpiggin@yahoo.com.au> wrote:

>>Feedback please, anyone.
>
>
> it looks good to me, but wouldnt it be simpler (in terms of patch and
> architecture impact) to always retry the follow_page() in
> get_user_pages(), in case of a minor fault? The sequence of minor faults

I believe this can break some things. Hugh posted an example
in his recent post to linux-mm (ptrace setting a breakpoint
in read-only text). I think?

--
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com