From: "H. Peter Anvin" <hpa@zytor.com>
To: Zachary Amsden <zach@vmware.com>
Cc: akpm@osdl.org, chrisl@vmware.com, davej@codemonkey.org.uk,
linux-kernel@vger.kernel.org, pratap@vmware.com,
Riley@Williams.Name
Subject: Re: [PATCH] 1/5 more-asm-cleanup
Date: Wed, 03 Aug 2005 23:01:25 -0700 [thread overview]
Message-ID: <42F1AF35.2080700@zytor.com> (raw)
In-Reply-To: <42F18638.5070108@vmware.com>
Zachary Amsden wrote:
> Please explain why this is a reject after looking at the cpuid macro.
> It changed recently. Note 0 -> %ecx.
Then just use cpuid_eax(4)? Or do those macros not behave that way?
> Would you prefer that I call cpuid_count and pass an explicit zero
> parameter for ecx?
I guess I really don't like the implicit zero when it matters, so yes.
-hpa
next prev parent reply other threads:[~2005-08-04 6:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-04 0:43 [PATCH] 1/5 more-asm-cleanup zach
2005-08-04 0:47 ` H. Peter Anvin
2005-08-04 3:06 ` Zachary Amsden
2005-08-04 6:01 ` H. Peter Anvin [this message]
2005-08-04 3:33 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42F1AF35.2080700@zytor.com \
--to=hpa@zytor.com \
--cc=Riley@Williams.Name \
--cc=akpm@osdl.org \
--cc=chrisl@vmware.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pratap@vmware.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox