[PATCH] 8139cp - redetect link after suspend

[PATCH] 8139cp - redetect link after suspend

[Pierre Ossman]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

After suspend the driver needs to retest link status in case the cable
has been inserted or removed during the suspend.

Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>

[-- Attachment #2: 8139cp-mii-suspend.patch --]
[-- Type: text/x-patch, Size: 608 bytes --]

Index: linux-wbsd/drivers/net/8139cp.c
===================================================================
--- linux-wbsd/drivers/net/8139cp.c	(revision 153)
+++ linux-wbsd/drivers/net/8139cp.c	(working copy)
@@ -1858,6 +1858,7 @@
 {
 	struct net_device *dev;
 	struct cp_private *cp;
+	unsigned long flags;
 
 	dev = pci_get_drvdata (pdev);
 	cp  = netdev_priv(dev);
@@ -1871,6 +1872,12 @@
 	
 	cp_init_hw (cp);
 	netif_start_queue (dev);
+
+	spin_lock_irqsave (&cp->lock, flags);
+
+	mii_check_media(&cp->mii_if, netif_msg_link(cp), FALSE);
+
+	spin_unlock_irqrestore (&cp->lock, flags);
 	
 	return 0;
 }

Re: [PATCH] 8139cp - redetect link after suspend

[John W. Linville]

On Mon, Jul 04, 2005 at 12:22:53AM +0200, Pierre Ossman wrote:
> After suspend the driver needs to retest link status in case the cable
> has been inserted or removed during the suspend.
> 
> Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>

Please copy netdev@vger.kernel.org for network driver patches.

Other than that, the patch looks acceptable to me, fwiw...

John
-- 
John W. Linville
linville@tuxdriver.com

Re: [PATCH] 8139cp - redetect link after suspend

[Pierre Ossman]

John W. Linville wrote:

>On Mon, Jul 04, 2005 at 12:22:53AM +0200, Pierre Ossman wrote:
>  
>
>>After suspend the driver needs to retest link status in case the cable
>>has been inserted or removed during the suspend.
>>
>>Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
>>    
>>
>
>Please copy netdev@vger.kernel.org for network driver patches.
>
>Other than that, the patch looks acceptable to me, fwiw...
>  
>

Has anyone had else had the time to review this? Jeff especially.

Rgds
Pierre